From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master 263ab75: ; Fix recent byte-compiler warning in dnd.el again
Date: Thu, 07 May 2020 21:21:23 +0100 [thread overview]
Message-ID: <87h7wrmr7g.fsf@tcd.ie> (raw)
In-Reply-To: <jwvo8qz1s74.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 07 May 2020 15:05:56 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> diff --git a/lisp/dnd.el b/lisp/dnd.el
>> index c185794..102bc75 100644
>> --- a/lisp/dnd.el
>> +++ b/lisp/dnd.el
>> @@ -101,6 +101,8 @@ is what has been dropped. Returns ACTION."
>> (throw 'done t)))
>> nil)
>> (catch 'done
>> + ;; Autoloaded but the byte-compiler still complains.
>> + (declare-function browse-url-select-handler "browse-url" (url))
>> (let ((browser (browse-url-select-handler url)))
>> (when browser
>> (setq ret 'private)
>
> It complains because the ;;;###autoload cookie had not yet been turned
> into an actual autoload in `lisp/loaddefs.el`.
> IOW what was missing was `cd lisp; make autoloads`.
That was my first thought as well, but 'make bootstrap' was still
complaining after verifying
$ grep browse-url-select-handler lisp/loaddefs.el
(autoload 'browse-url-select-handler "browse-url" "\
so I assumed the warning was due to bootstrapping order and added the
declaration anyway.
> I also get caught by those things every once in a while.
> It would be good to find a way to automatically guess when to run `make autoloads`.
Is it run in time as part of 'make bootstrap'?
--
Basil
next prev parent reply other threads:[~2020-05-07 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200507174021.29070.24637@vcs0.savannah.gnu.org>
[not found] ` <20200507174022.5B7BD20A15@vcs0.savannah.gnu.org>
2020-05-07 19:05 ` master 263ab75: ; Fix recent byte-compiler warning in dnd.el again Stefan Monnier
2020-05-07 20:21 ` Basil L. Contovounesios [this message]
2020-05-07 20:55 ` Stefan Monnier
2020-05-07 23:12 ` Basil L. Contovounesios
2020-06-13 15:16 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7wrmr7g.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).