From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Why are so many great packages not trying to get included in GNU Emacs? WAS: Re: Making Emacs more friendly to newcomers Date: Sat, 13 Jun 2020 21:30:38 +0100 Message-ID: <87h7ve7lox.fsf@tcd.ie> References: <87k12bdgx7.fsf@yahoo.com> <87r1wi7a8o.fsf@yahoo.com> <875zdteybt.fsf@runbox.com> <87368wrvf5.fsf@yahoo.com> <86k126d83n.wl-me@enzu.ru> <83pnbyckvv.fsf@gnu.org> <4923d7e98f5ed816a7569093dbc673153adcea88.camel@yandex.ru> <87tuzezrrl.fsf@tcd.ie> <7e47e9a4ccb739fbd0179d2b8ae3b7b48d19e316.camel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="102998"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , Emacs developers , Stefan Kangas , Dmitry Gutov To: Konstantin Kharlamov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 13 22:31:59 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jkCop-000Qf2-7e for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Jun 2020 22:31:59 +0200 Original-Received: from localhost ([::1]:49578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkCoo-0003yz-85 for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Jun 2020 16:31:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkCnd-0002m4-CN for emacs-devel@gnu.org; Sat, 13 Jun 2020 16:30:45 -0400 Original-Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:37476) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkCna-0006qv-Ap for emacs-devel@gnu.org; Sat, 13 Jun 2020 16:30:45 -0400 Original-Received: by mail-wr1-x441.google.com with SMTP id x13so13305229wrv.4 for ; Sat, 13 Jun 2020 13:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wyiQdlAfs1pPNECmxni75sMBMry5lrIOpIHS0YD7+OY=; b=k0eaoLcfcCR8pDwDdFqyj5P8iyhYMmxpEydtjFVIgTnTlDFy2KqfNv0wa2uAiOLo7r 39Sla7WdRDtdObYKawqkeoQNZ8qD/YlNaIiWVttXPu42WVqlnJi8bUPZcdARsufb9vE7 RgVuV/EjaotfmRQfJxhWDm1a/LezWh0fcCRVN2d8ze1IX+ytWBtVorDya9PBWMB8dsom J5IcM0htEDaNvt+v+2aWTc+OMDxzZSPA7wFrIHN5Uj0WbUzQ99g6y0Erz1dtzQyVelKT sK2RgIWleBM3KbrISw8ThYxX8JW3zpu2QsJmnnZsIR1BXdT2J/fRpU9/GPCIf/BM7E9C 3LEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wyiQdlAfs1pPNECmxni75sMBMry5lrIOpIHS0YD7+OY=; b=ev3k+anDfXO1N8rkeJH2pDd7B2eeu8Rke8cR1+M/MrDYIjBHGmKXY9vXkiyLIaKFxV wvEp2s/8VWtKp7KH94fJewakpW91IRD5V+3WmMJ6c4wdgXnLMKgaJmtNUGgPueHK2+qR PW9OWj0sYEDpC+FfolYSLLQNoCAlA9IAI/TLzORqUyJa/lqtPeS6Otli0pnuJqTvH+pp SZ06ng52S4Eoxmoa3VdzCHDVC7iEq4Wk/WmohPMlvbeB4VvIzT+wS2q7cY1jJH8Bj2ab Yw+/nQM66HfEKiYAiiNl3i1NuwANjCof0WXKgtSjLZBS7iWIoWokFtf+FiHJEnl/CA3l 8N0g== X-Gm-Message-State: AOAM530jBzd8Trz4+5UhXtHybka4MkCTfYR40D6KzyUdwjGUFqAFlnKe 6ofn4YeZpMsz7jZ421zOUBj3pg== X-Google-Smtp-Source: ABdhPJzHejCh54dbjkWcQrIawuybX7mSyfPfZtY7pmJSagU3jn6OnKm8jsEjLaar7OJy/wN7nHdqgQ== X-Received: by 2002:a5d:6a89:: with SMTP id s9mr21015392wru.15.1592080240687; Sat, 13 Jun 2020 13:30:40 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id a126sm15325320wme.28.2020.06.13.13.30.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2020 13:30:39 -0700 (PDT) In-Reply-To: <7e47e9a4ccb739fbd0179d2b8ae3b7b48d19e316.camel@yandex.ru> (Konstantin Kharlamov's message of "Sat, 13 Jun 2020 23:24:01 +0300") Received-SPF: none client-ip=2a00:1450:4864:20::441; envelope-from=contovob@tcd.ie; helo=mail-wr1-x441.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252206 Archived-At: Konstantin Kharlamov writes: > On Sat, 2020-06-13 at 20:31 +0100, Basil L. Contovounesios wrote: >> Konstantin Kharlamov writes: >> >> > FTR, I am all for having good commit messages. It is IMO a must have for any >> > git >> > project. But having a list of function names with description for each does >> > not >> > make one. >> >> FWIW, one great benefit of this list for me is that I can quickly >> 'git log --grep' for all commits that mention a particular definition. >> Doing the same with 'git log -G' is painfully slower and with a far >> lower signal:noise ratio. > > You can get that purely with git by using option `-L` of gitlong. It has syntax > `-L ::`. > > To give you example, I just looked at my recent change in python.el, and the > diff says the region belongs to `python-font-lock-keywords-maximum-decoration`. > So I execute: > > git log -L :python-font-lock-keywords-maximum- > decoration:lisp/progmodes/python.el > > And I get a log of commits that changed that function. Git version 2.27.0 And what if a commit message references a particular variable or function without touching the file that they're defined in? I'm talking about more general xrefing. >> > Instead it should be an overview of what is done, why, and how. >> >> That, or at the very least linking to the relevant bug/thread >> discussions, is always a good thing to do and encouraged. >> >> > Suppose you have a patch that deduplicates the same code pattern across 34 >> > functions by factoring it out to a single short function. Do you really need >> > that list? >> >> No, in such cases there are shortcuts you can take, such as "all callers >> changed". > > Oh, is that something new? It's older than I've been around these parts (~2016). > I'm just wondering, why when I did the change to > replace hex regexes with xdigit > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36167 I had to write all hundreds > of functions instead of a one liner "all callers are changed"? You didn't exactly. It is possible to take shortcuts depending on the context. See the file CONTRIBUTE or (info "(standards) Change Logs") https://www.gnu.org/prep/standards/html_node/Change-Logs.html. -- Basil