* "ignored" in *vc-dir* buffers
@ 2020-07-17 13:48 Lars Ingebrigtsen
2020-07-17 14:12 ` Dmitry Gutov
0 siblings, 1 reply; 10+ messages in thread
From: Lars Ingebrigtsen @ 2020-07-17 13:48 UTC (permalink / raw)
To: emacs-devel
When I'm checking stuff in in Emacs 28 now, I'm always getting
./
doc/misc/
* up-to-date doc/misc/eww.texi
etc/
* up-to-date etc/NEWS
lisp/net/
* ignored lisp/net/shr.el
or something like that. That is, a few of the lines will say "ignored"
while the rest say "up-to-date" as expected.
As far as I can tell, nothing is actually ignored...
This used to work better before... is this something other people are
seeing, or should I start debugging?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: "ignored" in *vc-dir* buffers
2020-07-17 13:48 "ignored" in *vc-dir* buffers Lars Ingebrigtsen
@ 2020-07-17 14:12 ` Dmitry Gutov
2020-07-17 14:25 ` Lars Ingebrigtsen
0 siblings, 1 reply; 10+ messages in thread
From: Dmitry Gutov @ 2020-07-17 14:12 UTC (permalink / raw)
To: Lars Ingebrigtsen, emacs-devel
On 17.07.2020 16:48, Lars Ingebrigtsen wrote:
> When I'm checking stuff in in Emacs 28 now, I'm always getting
>
> ./
> doc/misc/
> * up-to-date doc/misc/eww.texi
> etc/
> * up-to-date etc/NEWS
> lisp/net/
> * ignored lisp/net/shr.el
>
> or something like that. That is, a few of the lines will say "ignored"
> while the rest say "up-to-date" as expected.
>
> As far as I can tell, nothing is actually ignored...
>
> This used to work better before... is this something other people are
> seeing, or should I start debugging?
Can't reproduce. If I edit shr.el and save it, it shows up as "edited"
in the VC-Dir buffer.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: "ignored" in *vc-dir* buffers
2020-07-17 14:12 ` Dmitry Gutov
@ 2020-07-17 14:25 ` Lars Ingebrigtsen
2020-07-17 15:17 ` Dmitry Gutov
0 siblings, 1 reply; 10+ messages in thread
From: Lars Ingebrigtsen @ 2020-07-17 14:25 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: emacs-devel
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 17.07.2020 16:48, Lars Ingebrigtsen wrote:
>> When I'm checking stuff in in Emacs 28 now, I'm always getting
>> ./
>> doc/misc/
>> * up-to-date doc/misc/eww.texi
>> etc/
>> * up-to-date etc/NEWS
>> lisp/net/
>> * ignored lisp/net/shr.el
>> or something like that. That is, a few of the lines will say
>> "ignored"
>> while the rest say "up-to-date" as expected.
>> As far as I can tell, nothing is actually ignored...
>> This used to work better before... is this something other people
>> are
>> seeing, or should I start debugging?
>
> Can't reproduce. If I edit shr.el and save it, it shows up as "edited"
> in the VC-Dir buffer.
Yes, that works correctly. It's only when I check files in that they
switch to "ignored".
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: "ignored" in *vc-dir* buffers
2020-07-17 14:25 ` Lars Ingebrigtsen
@ 2020-07-17 15:17 ` Dmitry Gutov
2020-07-17 15:18 ` Lars Ingebrigtsen
2020-07-17 15:24 ` Dmitry Gutov
0 siblings, 2 replies; 10+ messages in thread
From: Dmitry Gutov @ 2020-07-17 15:17 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
On 17.07.2020 17:25, Lars Ingebrigtsen wrote:
> Yes, that works correctly. It's only when I check files in that they
> switch to "ignored".
Always?
I added a change to shr.el, made a commit. It because 'up-to-date'.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: "ignored" in *vc-dir* buffers
2020-07-17 15:17 ` Dmitry Gutov
@ 2020-07-17 15:18 ` Lars Ingebrigtsen
2020-07-17 15:24 ` Dmitry Gutov
1 sibling, 0 replies; 10+ messages in thread
From: Lars Ingebrigtsen @ 2020-07-17 15:18 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: emacs-devel
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 17.07.2020 17:25, Lars Ingebrigtsen wrote:
>> Yes, that works correctly. It's only when I check files in that they
>> switch to "ignored".
>
> Always?
>
> I added a change to shr.el, made a commit. It because 'up-to-date'.
Only some of the files...
OK, I'll try to debug and see what's up.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: "ignored" in *vc-dir* buffers
2020-07-17 15:17 ` Dmitry Gutov
2020-07-17 15:18 ` Lars Ingebrigtsen
@ 2020-07-17 15:24 ` Dmitry Gutov
2020-07-19 3:10 ` Lars Ingebrigtsen
1 sibling, 1 reply; 10+ messages in thread
From: Dmitry Gutov @ 2020-07-17 15:24 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
Sorry,
On 17.07.2020 18:17, Dmitry Gutov wrote:
> On 17.07.2020 17:25, Lars Ingebrigtsen wrote:
>> Yes, that works correctly. It's only when I check files in that they
>> switch to "ignored".
>
> Always?
>
> I added a change to shr.el, made a commit. It because 'up-to-date'.
^ became
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: "ignored" in *vc-dir* buffers
2020-07-17 15:24 ` Dmitry Gutov
@ 2020-07-19 3:10 ` Lars Ingebrigtsen
2020-07-19 3:46 ` Stefan Monnier
0 siblings, 1 reply; 10+ messages in thread
From: Lars Ingebrigtsen @ 2020-07-19 3:10 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: emacs-devel
OK, I've now debugged a bit.
If I edit a file under the lisp directory (but only there), I get these
weird results.
First, if I edit a file, I get the expected:
(vc-git-state "/home/larsi/src/emacs/trunk/lisp/vc/vc-git.el")
=> edited
But then if I remove the edit, then:
(vc-git-state "/home/larsi/src/emacs/trunk/lisp/vc/vc-git.el")
=> ignored
Outside the lisp directory, I get the expected:
(vc-git-state "/home/larsi/src/emacs/trunk/src/gnutls.c")
=> up-to-date
This is with "git version 2.27.0" in Debian sid.
And, indeed:
larsi@xo:~/src/emacs/trunk$ git status --porcelain --ignored -- lisp/vc/vc-git.el
!! lisp/vc/vc-git.elc
So... er... it's not an Emacs issue at all, but my git is broken?
Because "!!" means ignored. Or is my Emacs tree broken?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: "ignored" in *vc-dir* buffers
2020-07-19 3:10 ` Lars Ingebrigtsen
@ 2020-07-19 3:46 ` Stefan Monnier
2020-07-19 3:59 ` Lars Ingebrigtsen
0 siblings, 1 reply; 10+ messages in thread
From: Stefan Monnier @ 2020-07-19 3:46 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel, Dmitry Gutov
> larsi@xo:~/src/emacs/trunk$ git status --porcelain --ignored -- lisp/vc/vc-git.el
> !! lisp/vc/vc-git.elc
^^^
What's this "c"?
Stef
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: "ignored" in *vc-dir* buffers
2020-07-19 3:46 ` Stefan Monnier
@ 2020-07-19 3:59 ` Lars Ingebrigtsen
2020-07-19 6:43 ` Andreas Schwab
0 siblings, 1 reply; 10+ messages in thread
From: Lars Ingebrigtsen @ 2020-07-19 3:59 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel, Dmitry Gutov
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> larsi@xo:~/src/emacs/trunk$ git status --porcelain --ignored --
>> lisp/vc/vc-git.el
>> !! lisp/vc/vc-git.elc
> ^^^
> What's this "c"?
Oh yeah! Good catch.
It looks like this git is interpreting the path spec not as an absolute
name, but as a prefix?
larsi@xo:~/src/emacs/trunk$ git status --porcelain --untracked-files --ignored -- src/gnutls
!! src/gnutls.o
Yup!
larsi@xo:~/src/emacs/trunk$ git status --porcelain --untracked-files --ignored -- src/g
!! src/gl-stamp
!! src/globals.h
!! src/globals.h.~1~
!! src/gnutls.o
!! src/gtkutil.o
Older versions of git doesn't interpret PATHSPEC this way, and I can't
see that the manual says anything about this, either...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-07-19 6:43 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-17 13:48 "ignored" in *vc-dir* buffers Lars Ingebrigtsen
2020-07-17 14:12 ` Dmitry Gutov
2020-07-17 14:25 ` Lars Ingebrigtsen
2020-07-17 15:17 ` Dmitry Gutov
2020-07-17 15:18 ` Lars Ingebrigtsen
2020-07-17 15:24 ` Dmitry Gutov
2020-07-19 3:10 ` Lars Ingebrigtsen
2020-07-19 3:46 ` Stefan Monnier
2020-07-19 3:59 ` Lars Ingebrigtsen
2020-07-19 6:43 ` Andreas Schwab
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).