From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: empty-directory predicate, native implementation Date: Thu, 15 Oct 2020 14:21:40 +0200 Message-ID: <87h7qvptm3.fsf@gmx.de> References: <83y2ka18t7.fsf@gnu.org> <87y2kaj799.fsf@gmx.de> <83blh60wgr.fsf@gnu.org> <87h7qxjh7g.fsf@gmx.de> <878sc8kgy8.fsf@gmx.de> <87imbcls71.fsf@gmx.de> <83eem0zt0b.fsf@gnu.org> <87k0vsrd6m.fsf@gmx.de> <83a6wozs7h.fsf@gnu.org> <87sgafq2e2.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28468"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Arthur Miller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 15 14:25:16 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kT2Jo-0007Iv-7o for ged-emacs-devel@m.gmane-mx.org; Thu, 15 Oct 2020 14:25:16 +0200 Original-Received: from localhost ([::1]:50342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kT2Jm-00005E-Ua for ged-emacs-devel@m.gmane-mx.org; Thu, 15 Oct 2020 08:25:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60876) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kT2GV-0007RO-4U for emacs-devel@gnu.org; Thu, 15 Oct 2020 08:21:51 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:41309) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kT2GR-00070R-W3; Thu, 15 Oct 2020 08:21:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1602764501; bh=yYi5mazlo9CYFU1JCT1dRxXFMf1oJaBYIxXqb7l2yQY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=CnzN8hKlQR22RraWqNHfLafjIrVAUu0lNAwvT4XswQQZ1O23zgO5JVlSVEuM9meKo OOpAJSi8r0UsjWTEjiirLO61S1HsrmoHVYtIxxcCvcqkZ2cjWZ3/zESeeesKqzYj6I sHNMIDLPhTQsmyyNWJ4rhEfH2VvR31lFndd+Bh04= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([178.20.90.152]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MMofc-1klnZB2RrI-00IjeC; Thu, 15 Oct 2020 14:21:41 +0200 In-Reply-To: (Arthur Miller's message of "Thu, 15 Oct 2020 13:33:54 +0200") X-Provags-ID: V03:K1:EjDpyj8v0CtHm8SfpotIusVzCP95Wl/3Ztg2eyYzWQuc0zZoNdG 7eYLoN3KELZA2KUYUl1tF/aHWF5u2Am/OygORVpkz/yo/JuaUEWlp/63oGFVPpH3EYV+mv/ pmul5s7+zkRWcUS7vvjkNXj6JIi3yWX7wmROzmoQ19If10hAKIrYuT1vixsacHfzwnaArBv a8pF6fXoK9tGeAFC2Pr5A== X-UI-Out-Filterresults: notjunk:1;V03:K0:tUxQHw+WD8o=:MvSUfVeNhGnGug3y8HMAYh NGBBq2dZbO26fU2KZYX3iIJK/lFo3umaQeEmi+VCVmx9hDzXgaALlumJlPPUrSMBY6NCA4ozW INaGANF0Jceb6CKkQY8CjNxCiWga2F3nhrNJmKBq3wpLZFJ8iJUduQXBgjwg8OaErQptsYKEl j7/E1xkJTLanh7YgE2Yn2x/5oqKT75b2gmQmSCShqo4scWfpLWsoW3JcSH7kwT5Ma1q/542YE p85vff6PK2v6OFHmBUMtUO6SXf+Ivj5Q0R5VEp8woVCzYFFUW1MsJUcnS90C1BxqB1Q8K0szC rVHr2eHfLWEDVHUxL6kIbeO/4BnG+ahmvX+BQtX3MU2z6p3G3K8pswrsRJLYLr1Dk8pXdeP8S kaqMPl3EJo0Pg7tE2Pqr5mMam2gCw7yw5MvJ3gUmy56jgUKgtbTBeYaNTQ4JLvyD6E5yITnYP 0BopYEhdtPdP1DRkHTuOdtfz7W/KqPERiroEne1ZFU/Tsu9sEkhSczyEI+r82EFdP5jOu/KT4 acs58nV6wUyQAgQ4Qrh2GLXlghq1xtNHwBdE4m7kxUs3bQs+m2H+nakSCZ+2ErBEgSrTwVpRk gp6d7rPli476HkBvNC9aKU2VymszxbVFKjiEaAv0M28vi/oayLAEms+pZAJDE1sU9Z0uvPfM7 Byo28XxlwF6ObhT3Ol966f2QV3Jva1y85bs7HYFxczep2Hzn9FY7rkmtlXgopaOnBTW01J7Xg DyafT0Ax5Fdbv/IMSRDWLGzMZDekyELJ6djs0YPvpN5rDYYsp1+KxyE4Wqj0u8PLh+C9/J1U Received-SPF: pass client-ip=212.227.17.22; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/15 07:34:37 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257718 Archived-At: Arthur Miller writes: Hi Arthur, >> Thanks for this. I haven't seen your name on the FSF file; I guess your >> legal papers are on the way? > They are not, but they can be if someone send me link. I've been looking > at this page: > > https://www.gnu.org/prep/maintain/html_node/Copyright-Papers.html#Copyright-Papers > > but I am not really sure where do I send request. Sorry, I should have asked. I'll send you the template off-list. >> - Adapt the file name handlers. These are ange-ftp-directory-files, >> ange-ftp-directory-files-and-attributes, tramp-handle-directory-files, >> tramp-handle-directory-files-and-attributes, >> tramp-adb-handle-directory-files-and-attributes, >> tramp-crypt-handle-directory-files, >> tramp-rclone-handle-directory-files, >> tramp-sh-handle-directory-files-and-attributes, >> tramp-smb-handle-directory-files. > > Aha, so it is how it works; didn't have time to look into tramp yet. > Ok, I'll do; I'll sent in patch(es) when I am done. Probably not today > though but during the weekend of beginning of the next week. There's no rush. Doing the legal work will take a week or so. > So many changes just for one signature :-). In order to enjoy you: Tramp is backward compatible back to Emacs 25. This must also be taken into account :-) But don't worry, I'll make the needed changes after your commit. >> - Adapt resp extend ERT tests. These are tramp-test16-directory-files, >> tramp-test19-directory-files-and-attributes, >> tramp-archive-test16-directory-files and >> tramp-archive-test19-directory-files-and-attributes. >> >> - Optionally (but much appreciated), write new ERT tests for >> directory-files and directory-files-and-attributes. > > Will have to look at ERT, I suppose it is not too complicated, > opportunity to learn it. A look at the ert manual might help. (info "(ert)") > I mainly try to be clear "what I intent" for some future reader; since > previous code uses lisp.h macros, I used same. I thought that one extra > 'if' is not that much of a penalty, I'll gladly shortcircut with !last. In case you feel the need, you could also provide a comment. Best regards, Michael.