From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Poll: Change xref-show-definitions-function's default? Date: Thu, 07 Jan 2021 19:47:07 +0200 Organization: LINKOV.NET Message-ID: <87h7nsslqk.fsf@mail.linkov.net> References: <9af40a30-8964-3142-aadf-6592605720ec@yandex.ru> <871rf0ob2c.fsf@mail.linkov.net> <7b108ef2-7798-19b9-f37d-680bdcb23745@yandex.ru> <87czyh52rj.fsf@mail.linkov.net> <07c6166d-119a-6479-03ed-2bde5c51959f@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18306"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 07 18:56:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxZVu-0004bQ-DE for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Jan 2021 18:55:58 +0100 Original-Received: from localhost ([::1]:36278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxZVt-0003Qg-FU for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Jan 2021 12:55:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxZUj-0001mm-Eg for emacs-devel@gnu.org; Thu, 07 Jan 2021 12:54:45 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:34113) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxZUf-0001YU-Sd for emacs-devel@gnu.org; Thu, 07 Jan 2021 12:54:45 -0500 X-Originating-IP: 91.129.98.64 Original-Received: from mail.gandi.net (m91-129-98-64.cust.tele2.ee [91.129.98.64]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 6593EFF803; Thu, 7 Jan 2021 17:54:36 +0000 (UTC) In-Reply-To: <07c6166d-119a-6479-03ed-2bde5c51959f@yandex.ru> (Dmitry Gutov's message of "Wed, 6 Jan 2021 22:55:21 +0200") Received-SPF: pass client-ip=217.70.183.199; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262698 Archived-At: >> I'm afraid the default of xref-show-definitions-function can't be changed >> to xref-show-definitions-completing-read because as this poll indicates >> it works satisfactorily only in combination with icomplete-mode and >> also non-nil icomplete-show-matches-on-no-input. > > What about xref-show-definitions-buffer-at-bottom, then? Sorry, I have no opinion about xref-show-definitions-buffer-at-bottom, I'm using xref-show-definitions-completing-read with icomplete. >>> Then we can safely remove/change the TAB binding in xref--xref-buffer-mode, >>> or alternatively, create a new major mode that is slightly more Grep-like, >>> and use it in the default xref-show-xrefs-function. >> Maybe a new submode could help to resolve this discrepancy. > > Yes, that's the second option I meant. Maybe the TAB keybinding should depend on the value of xref-show-definitions-function. When it is customized to xref-show-definitions-completing-read then don't bind TAB.