unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master 8f28a1b: Tweak `condition-case' keyword highlights
Date: Sun, 24 Jan 2021 23:50:31 +0100	[thread overview]
Message-ID: <87h7n6osp4.fsf@gnus.org> (raw)
In-Reply-To: <87o8heovpm.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 24 Jan 2021 22:45:25 +0100")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Couldn't we just use `edebug-form-spec' to notice that the arglist isn't
> a funcall position?  That would get a huge number of macros/special
> forms with non-funcall positions right...
> `lisp--el-non-funcall-position-p' would have to parse that, though,
> which might slow things down?

Looking at this a bit more, parsing the edebug spec should be fast
enough, but we'd then need to know what the position of the current sexp
is in its enclosing form?  `parse-partial-sexp' doesn't return this
data...  Skimming scan_sexps_forward, adding a counter doesn't seem
impossible there?  Would that make sense?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  parent reply	other threads:[~2021-01-24 22:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210124203118.16450.28084@vcs0.savannah.gnu.org>
     [not found] ` <20210124203120.0ABC320AD1@vcs0.savannah.gnu.org>
2021-01-24 21:32   ` master 8f28a1b: Tweak `condition-case' keyword highlights Stefan Monnier
2021-01-24 21:45     ` Lars Ingebrigtsen
2021-01-24 22:07       ` [External] : " Drew Adams
2021-01-24 22:50       ` Lars Ingebrigtsen [this message]
2021-01-24 23:10       ` Stefan Monnier
2021-01-26  0:25         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7n6osp4.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).