From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: scratch/command 064f146 1/2: Change command to interactive ... modes Date: Wed, 17 Feb 2021 10:58:13 +0200 Organization: LINKOV.NET Message-ID: <87h7mbdpou.fsf@mail.linkov.net> References: <20210213141225.11309.86562@vcs0.savannah.gnu.org> <87eehid3k2.fsf@gnus.org> <87r1liblzb.fsf@gnus.org> <83y2fq9f0v.fsf@gnu.org> <87k0r8xl7y.fsf@gnus.org> <834kic9g0a.fsf@gnu.org> <8735xwvusc.fsf@gnus.org> <83v9as7xns.fsf@gnu.org> <87pn10ueld.fsf@gnus.org> <83r1lf9apm.fsf@gnu.org> <87a6s3vrnd.fsf@gnus.org> <83o8gj9a8o.fsf@gnu.org> <871rdfvq86.fsf@gnus.org> <83h7mb98g8.fsf@gnu.org> <87o8gjuaez.fsf@gnus.org> <83ft1v97bk.fsf@gnu.org> <877dn7u7wq.fsf@gnus.org> <835z2r94zw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28354"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , emacs-devel@gnu.org, Lars Ingebrigtsen , dgutov@yandex.ru To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 17 10:39:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCJJ2-0007GU-Ts for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Feb 2021 10:39:36 +0100 Original-Received: from localhost ([::1]:60520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCJJ1-0001tx-UJ for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Feb 2021 04:39:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCJI2-0000sp-Jy for emacs-devel@gnu.org; Wed, 17 Feb 2021 04:38:34 -0500 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:45379) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCJI0-0002yR-CA; Wed, 17 Feb 2021 04:38:34 -0500 X-Originating-IP: 91.129.96.116 Original-Received: from mail.gandi.net (m91-129-96-116.cust.tele2.ee [91.129.96.116]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 5400F40009; Wed, 17 Feb 2021 09:38:25 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Tue, 16 Feb 2021 14:30:08 -0600") Received-SPF: pass client-ip=217.70.183.194; envelope-from=juri@linkov.net; helo=relay2-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264980 Archived-At: > To my mind, if two forms of writing the same thing are equally clear and > easy to understand, the less verbose one is often the better choice. > But I would claim that the more verbose form in this case is less clear > and harder to understand. The question is how this form is less clear and harder to understand: (defun Info-follow-reference (footnotename &optional fork) (declare (completion Info-mode)) ================================ (interactive (let ((completion-ignore-case t) (case-fold-search t) completions default alt-default (start-point (point)) str i bol eol) (save-excursion ;; Store end and beginning of line. (setq eol (line-end-position) bol (line-beginning-position)) (goto-char (point-min)) (while (re-search-forward "\\*note[ \n\t]+\\([^:]*\\):" nil t) (setq str (match-string-no-properties 1)) ;; See if this one should be the default. (and (null default) (<= (match-beginning 0) start-point) (<= start-point (point)) (setq default t)) ;; See if this one should be the alternate default. (and (null alt-default) (and (<= bol (match-beginning 0)) (<= (point) eol)) (setq alt-default t)) (setq i 0) (while (setq i (string-match "[ \n\t]+" str i)) (setq str (concat (substring str 0 i) " " (substring str (match-end 0)))) (setq i (1+ i))) ;; Record as a completion and perhaps as default. (if (eq default t) (setq default str)) (if (eq alt-default t) (setq alt-default str)) ;; Don't add this string if it's a duplicate. (or (assoc-string str completions t) (push str completions)))) ;; If no good default was found, try an alternate. (or default (setq default alt-default)) ;; If only one cross-reference found, then make it default. (if (eq (length completions) 1) (setq default (car completions))) (if completions (let ((input (completing-read (if default (concat "Follow reference named (default " default "): ") "Follow reference named: ") completions nil t))) (list (if (equal input "") default input) current-prefix-arg)) (user-error "No cross-references in this node")))) than what we have now in master (see the difference at the end): (defun Info-follow-reference (footnotename &optional fork) (interactive (let ((completion-ignore-case t) (case-fold-search t) completions default alt-default (start-point (point)) str i bol eol) (save-excursion ;; Store end and beginning of line. (setq eol (line-end-position) bol (line-beginning-position)) (goto-char (point-min)) (while (re-search-forward "\\*note[ \n\t]+\\([^:]*\\):" nil t) (setq str (match-string-no-properties 1)) ;; See if this one should be the default. (and (null default) (<= (match-beginning 0) start-point) (<= start-point (point)) (setq default t)) ;; See if this one should be the alternate default. (and (null alt-default) (and (<= bol (match-beginning 0)) (<= (point) eol)) (setq alt-default t)) (setq i 0) (while (setq i (string-match "[ \n\t]+" str i)) (setq str (concat (substring str 0 i) " " (substring str (match-end 0)))) (setq i (1+ i))) ;; Record as a completion and perhaps as default. (if (eq default t) (setq default str)) (if (eq alt-default t) (setq alt-default str)) ;; Don't add this string if it's a duplicate. (or (assoc-string str completions t) (push str completions)))) ;; If no good default was found, try an alternate. (or default (setq default alt-default)) ;; If only one cross-reference found, then make it default. (if (eq (length completions) 1) (setq default (car completions))) (if completions (let ((input (completing-read (if default (concat "Follow reference named (default " default "): ") "Follow reference named: ") completions nil t))) (list (if (equal input "") default input) current-prefix-arg)) (user-error "No cross-references in this node"))) Info-mode) =========