From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Current mode command discovery Date: Thu, 18 Feb 2021 15:06:22 +0100 Message-ID: <87h7m9wjvl.fsf@gnus.org> References: <87v9aubm96.fsf@gnus.org> <87czwzfn9p.fsf@telefonica.net> <87eehfnd83.fsf@gnus.org> <1fb773f6-1480-53ce-08ae-1f7d0ba23428@yandex.ru> <87k0r637k4.fsf@gnus.org> <80e8c434-888d-23c5-13f0-c513bbf13ee4@yandex.ru> <8735xtznrh.fsf@gnus.org> <70fd2374-23ea-1c03-a4e4-97a370a41acf@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10956"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: =?utf-8?Q?=C3=93scar?= Fuentes , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 18 15:08:36 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCjyu-0002kb-66 for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Feb 2021 15:08:36 +0100 Original-Received: from localhost ([::1]:42548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCjyt-00071j-4z for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Feb 2021 09:08:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52946) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCjwv-0004oK-CZ for emacs-devel@gnu.org; Thu, 18 Feb 2021 09:06:34 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:37642) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCjwt-0004BN-4n for emacs-devel@gnu.org; Thu, 18 Feb 2021 09:06:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xvg2Zky5KBZhlWgfTfBRb2h03mOEu7XgP6f3zQoxEA4=; b=W69w7UPHcbkhANAOyPoQ6k40Do wfFljTSyWCBwOcu0rAd/Vkn01DU31LgpWf4i5sfy/q7IZAjNE2XCqrw1qyhpb5qmZXfWg56vtel00 +qM+BgaqOH2hY1UwBsF80KC37Ui7IDBLFy6ZEIWBvrPR40AYmsSt6gXrLbM6Kaq6gOj8=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCjwm-0006PX-1A; Thu, 18 Feb 2021 15:06:27 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEXAvbtYVFQaFxaC fn1CPj3///9NXWpUAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UCEg07NvFdBRcAAAGUSURBVDjLlZPh ccMgDIVFyQAoaAG3DIAPDxBc7T9Tn4Sd2Jf4R5Xc5dCH3hOCEIXvj0HxCtz4ArxLlVX5/gbWNVYi +jqDMjUKjeIRSOFGNGGJL/fhocoLeSRqi5izV0y3SiFRTI3LkJyw20AAqE1eXhNFO+AUjklvgm6f zoH4vV8An1W8Gsm/wVlKVddPFaqDFNUTKJb/1g8AidVKDBw9SmeUFDXJE0gUsN3QWUorLSa1g1LW 4r690uwmugHdouOqwtjf+Qge9gyki+UBwhNkrpVEeYDtuBasPZMIK/MZqMAl39hq9AU6z8StUZvd xEGHJueWY20NDSzDowhv8aDcWptr2ABS0r2Tzhk1eKJ7hWVNrQcIwoWWraILO8iuCJvwBPjwM4jg NAAPqVEHwHtXYjeElXeQduBdieXY+lA8fD54eAUmKOr/HIBpNgAVn11eMC8MBeAnmjWk1EaQJFey gwFAUvauON153I8Bmj3n6xTmLrIDkv2qONGSDgBPoA/4oD62DYA+NqDxQXoAUZ4Xn6L//gH595y9 KSPg3wAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0wMi0xOFQxMzo1OTo1MyswMDowME86TgYAAAAl dEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDItMThUMTM6NTk6NTMrMDA6MDA+Z/a6AAAAAElFTkSuQmCC X-Now-Playing: John Coltrane's _A Love Supreme_: "Part 3: Pursuance" In-Reply-To: <70fd2374-23ea-1c03-a4e4-97a370a41acf@yandex.ru> (Dmitry Gutov's message of "Thu, 18 Feb 2021 15:05:34 +0200") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265151 Archived-At: Dmitry Gutov writes: > On 18.02.2021 12:14, Lars Ingebrigtsen wrote: >> I guess the main performance difference is in loading the .elc files -- >> parsing and applying all the `put's. > > Hm. Are you saying that the use of (declare (completion ...)) form > currently requires us to parse all .elc files? No -- I'm saying that I guess the M-x completion performance difference is probably very small between the two approaches. The current approach is to stash the data in the bytecode object and retrieving it with `command-modes' vs. doing `get' on the symbol. `command-modes' is O(1) and `get' is O(n), but the n is so small on typical symbols that I doubt there's much of a measurable difference. And `get' has a bytecode opcode, so it may even be faster for all I know. But I haven't measured. The disadvantage in using a `put' for this data is mainly in that it makes .elc files larger (and therefore slower to load). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no