From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 12409c9: New transient mode 'repeat-mode' to allow shorter key sequences (bug#46515) Date: Thu, 18 Feb 2021 19:29:10 +0200 Organization: LINKOV.NET Message-ID: <87h7m9co2d.fsf@mail.linkov.net> References: <20210217180506.28704.14280@vcs0.savannah.gnu.org> <20210217180507.C061220DFB@vcs0.savannah.gnu.org> <87lfbln1w8.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4865"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 18 18:44:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCnLZ-00018j-Ib for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Feb 2021 18:44:13 +0100 Original-Received: from localhost ([::1]:47290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCnLY-0002VN-KB for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Feb 2021 12:44:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCnCj-0003cE-6p for emacs-devel@gnu.org; Thu, 18 Feb 2021 12:35:05 -0500 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:60579) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCnCh-0004PX-9V for emacs-devel@gnu.org; Thu, 18 Feb 2021 12:35:04 -0500 Original-Received: from mail.gandi.net (m91-129-96-116.cust.tele2.ee [91.129.96.116]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id D1482200005; Thu, 18 Feb 2021 17:34:58 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Thu, 18 Feb 2021 10:32:23 -0500") Received-SPF: pass client-ip=217.70.178.232; envelope-from=juri@linkov.net; helo=relay12.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265168 Archived-At: >>>> +(defvar next-error-repeat-map >>>> + (let ((map (make-sparse-keymap))) >>>> + (define-key map "n" 'next-error) >>>> + (define-key map "\M-n" 'next-error) >>>> + (define-key map "p" 'previous-error) >>>> + (define-key map "\M-p" 'previous-error) >>>> + map) >>>> + "Keymap to repeat next-error key sequences. Used in `repeat-mode'.") >>>> +(put 'next-error 'repeat-map 'next-error-repeat-map) >>>> +(put 'previous-error 'repeat-map 'next-error-repeat-map) >>> >>> Could we avoid this duplication between the map and the >>> `repeat-map` property? > > There is in the above code snippet: the `put` statements are redundant > since the same info is fundamentally already available from > `next-error-repeat-map`. Now I see where is duplication. But currently I have no idea in what keymaps post-command-hook should look for keybindings. When a command is associated with a keymap `next-error-repeat-map` via `put` property, then post-command-hook knows where to look for keybindings for the current command (using `this-command`).