From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master a0f6029: Fix misuses of `byte-compile-macro-environment` Date: Wed, 03 Mar 2021 14:44:02 +0000 Message-ID: <87h7lsthzh.fsf@tcd.ie> References: <20210301171853.8051.45984@vcs0.savannah.gnu.org> <20210301171854.C42CB20E1B@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40048"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 03 15:45:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHSkl-000AKq-C2 for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 15:45:31 +0100 Original-Received: from localhost ([::1]:53050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHSkk-0006MI-Eq for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 09:45:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHSjV-0005aO-AX for emacs-devel@gnu.org; Wed, 03 Mar 2021 09:44:15 -0500 Original-Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:40194) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHSjQ-0001Pl-E3 for emacs-devel@gnu.org; Wed, 03 Mar 2021 09:44:12 -0500 Original-Received: by mail-wm1-x32c.google.com with SMTP id o2so6066868wme.5 for ; Wed, 03 Mar 2021 06:44:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XvRqfImkK4X9l4p8Uq1YqeVJIzRq6gTlGiApAocunJc=; b=X1laQ6Wb39QV3+QPb10Mwt+nZEbZJeJf6zXpYe9QpXRRYn4Mhq4BTW7YlaKgrzwC82 lTMIxGTSor1Nl7jCrJ7iU+bWJ1fK0kVhZjIBWtSYfuYj0Jnf+B4dKD6POnuRRuMn2j3M LOFEqz9UmPPg/L6VtL84gkZIIlbDrTOlCi9CmxKWQgnSk1fxQgJ6jWswT9JSSajKk6MO 6SMOiTgc+qXizzzx6NIMDg3ykFNN0O67IZYIeJHQvvKn+lj7xMXX1ryLhaGGY0VjSQ2S DqzzrK360Ovd6O+EiPmQUUlXZAYqrm/mWqYv36AgrtFval/ZMFKWMWEw76UYp9cC3IRR OZ6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XvRqfImkK4X9l4p8Uq1YqeVJIzRq6gTlGiApAocunJc=; b=sQm39EqdPnaHgAENmSNxoW7CPZnHLtj5usaKP0je9BUVkHero1v+V7wMSLxJaiHx0r ktxHHGugo9rtWDrRFJkaKf8lTIiD2dfVOfVxueCC2/Ejs9t+mhc6wgaj24nnYLoX25AJ 8evzozDvcrC0XUFwTI5rDApqDwdJQ68E0zBkyIGCzl6kuuf6/LEl0T8iS3T9JhT/MvAg H0tnp9NAYUUDQjYhdYd9LeMxcz2Ylnn3Gq0nzn8uDdHqGKnQksmWBtR81poNhrGzvX/L x7r4ZiG9xCVgV/+1ssCD+U12Aaqx6VIhcUR5sWJUGXf3yxVSX0LWmFYcLD8Z6n8ME3m/ o9zA== X-Gm-Message-State: AOAM533+WUllGge0n98uMiNMwjUYy7WEzOfz96Txsv7DH9eSZdfWAs8+ hlVQD93EpMTQrnKJBk08mpmMJRaIf4LE9w== X-Google-Smtp-Source: ABdhPJzFPOZ0kbvBF2KxSlTTgo7EVqZyALog2LgKEKaFJ+5S8VLBfNGNjC9J+X69twu3a78O60RMfg== X-Received: by 2002:a1c:9854:: with SMTP id a81mr9043056wme.19.1614782644974; Wed, 03 Mar 2021 06:44:04 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id c128sm6479308wma.37.2021.03.03.06.44.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 06:44:04 -0800 (PST) In-Reply-To: <20210301171854.C42CB20E1B@vcs0.savannah.gnu.org> (Stefan Monnier's message of "Mon, 1 Mar 2021 12:18:54 -0500 (EST)") Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=contovob@tcd.ie; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265883 Archived-At: --=-=-= Content-Type: text/plain monnier@iro.umontreal.ca (Stefan Monnier) writes: > branch: master > commit a0f60293d97cda858c033db4ae074e5e5560aab2 > Author: Stefan Monnier > Commit: Stefan Monnier > > Fix misuses of `byte-compile-macro-environment` This seems to result in the following test failure with 'make check', but strangely not with 'make test/pcase-tests': Test pcase-tests-macro backtrace: signal(void-function (pcase-tests-plus--pcase-macroexpander)) apply(signal (void-function (pcase-tests-plus--pcase-macroexpander)) #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name pcase-tests-macro :documentation nil ert-run-or-rerun-test(#s(ert--stats :selector (not (or ... ...)) :te ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/pcase-tes command-line() normal-top-level() Test pcase-tests-macro condition: (void-function pcase-tests-plus--pcase-macroexpander) FAILED 5/9 pcase-tests-macro (0.000163 sec) BTW, 'make bootstrap' now emits this warning: In cl--sm-macroexpand: emacs-lisp/cl-macs.el:2301:61: Warning: Unused lexical argument `dontcare' (The 'sm' is the artist's signature, right? ;) Is this the right fix? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Pacify-unused-var-warning-in-cl-sm-macroexpand.patch >From a29983cbbfb1fbd7cb2773d1e2dc89483df82bf4 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Wed, 3 Mar 2021 12:49:31 +0000 Subject: [PATCH] ; Pacify unused var warning in cl--sm-macroexpand. --- lisp/emacs-lisp/cl-macs.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el index 91146c4d0e..c38dc44ff6 100644 --- a/lisp/emacs-lisp/cl-macs.el +++ b/lisp/emacs-lisp/cl-macs.el @@ -2298,7 +2298,7 @@ cl--sm-macroexpand ;; The behavior of CL made sense in a dynamically scoped ;; language, but nowadays, lexical scoping semantics is more often ;; expected. - (`(,(or 'let 'let*) . ,(or `(,bindings . ,body) dontcare)) + (`(,(or 'let 'let*) . ,(or `(,bindings . ,body) pcase--dontcare)) (let ((nbs ()) (found nil)) (dolist (binding bindings) (let* ((var (if (symbolp binding) binding (car binding))) -- 2.30.1 --=-=-= Content-Type: text/plain Thanks, -- Basil --=-=-=--