monnier@iro.umontreal.ca (Stefan Monnier) writes:

> branch: master
> commit a0f60293d97cda858c033db4ae074e5e5560aab2
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     Fix misuses of `byte-compile-macro-environment`

This seems to result in the following test failure with 'make check',
but strangely not with 'make test/pcase-tests':

  Test pcase-tests-macro backtrace:
    signal(void-function (pcase-tests-plus--pcase-macroexpander))
    apply(signal (void-function (pcase-tests-plus--pcase-macroexpander))
    #f(compiled-function () #<bytecode -0x130ab4f40ca06d1f>)()
    ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
    ert-run-test(#s(ert-test :name pcase-tests-macro :documentation nil 
    ert-run-or-rerun-test(#s(ert--stats :selector (not (or ... ...)) :te
    ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
    ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
    ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
    eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
    command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/pcase-tes
    command-line()
    normal-top-level()
  Test pcase-tests-macro condition:
      (void-function pcase-tests-plus--pcase-macroexpander)
     FAILED  5/9  pcase-tests-macro (0.000163 sec)

BTW, 'make bootstrap' now emits this warning: 

  In cl--sm-macroexpand:
  emacs-lisp/cl-macs.el:2301:61: Warning: Unused lexical argument `dontcare'

(The 'sm' is the artist's signature, right? ;)

Is this the right fix?