* Re: master 80e2647: * lisp/filesets.el: Use lexical-binding [not found] ` <20210104232349.75BA220CB7@vcs0.savannah.gnu.org> @ 2021-03-12 16:23 ` Lars Ingebrigtsen 2021-03-12 16:59 ` Stefan Monnier 0 siblings, 1 reply; 2+ messages in thread From: Lars Ingebrigtsen @ 2021-03-12 16:23 UTC (permalink / raw) To: emacs-devel; +Cc: Stefan Monnier monnier@iro.umontreal.ca (Stefan Monnier) writes: > * lisp/filesets.el: Use lexical-binding A new warning popped up recently (I think) -- but this patch is almost two months old, so I'm not sure it's relevant or not. Anyway: In filesets-cmd-isearch-getargs: filesets.el:1627:17: Warning: global/dynamic var `files' lacks a prefix And indeed: (defun filesets-cmd-isearch-getargs () "Get arguments for `multi-isearch-files' and `multi-isearch-files-regexp'." (and (boundp 'files) (list files))) Now, filesets.el is a twisty maze of functions, but this seems to be called via the `filesets-commands' alist, and `filesets-cmd-get-def' which is called from `filesets-cmd-get-fn', which is called from `filesets-run-cmd'. Which binds `files' lexically, but is probably what `filesets-cmd-isearch-getargs' is trying to access? I'm not really confident about that analysis, though... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master 80e2647: * lisp/filesets.el: Use lexical-binding 2021-03-12 16:23 ` master 80e2647: * lisp/filesets.el: Use lexical-binding Lars Ingebrigtsen @ 2021-03-12 16:59 ` Stefan Monnier 0 siblings, 0 replies; 2+ messages in thread From: Stefan Monnier @ 2021-03-12 16:59 UTC (permalink / raw) To: Lars Ingebrigtsen; +Cc: emacs-devel > Now, filesets.el is a twisty maze of functions, but this seems to be > called via the `filesets-commands' alist, and `filesets-cmd-get-def' > which is called from `filesets-cmd-get-fn', which is called from > `filesets-run-cmd'. Which binds `files' lexically, but is probably what > `filesets-cmd-isearch-getargs' is trying to access? > > I'm not really confident about that analysis, though... Ah the wonderful world of dynamic scoping ;-) I agree with your analysis and pushed a patch that presumes you were right. Stefan ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-12 16:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210104232347.21177.41247@vcs0.savannah.gnu.org>
[not found] ` <20210104232349.75BA220CB7@vcs0.savannah.gnu.org>
2021-03-12 16:23 ` master 80e2647: * lisp/filesets.el: Use lexical-binding Lars Ingebrigtsen
2021-03-12 16:59 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).