From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 80e2647: * lisp/filesets.el: Use lexical-binding Date: Fri, 12 Mar 2021 17:23:03 +0100 Message-ID: <87h7lguys8.fsf@gnus.org> References: <20210104232347.21177.41247@vcs0.savannah.gnu.org> <20210104232349.75BA220CB7@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16628"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 12 17:25:01 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKkax-00047A-Bd for ged-emacs-devel@m.gmane-mx.org; Fri, 12 Mar 2021 17:24:59 +0100 Original-Received: from localhost ([::1]:58132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKkaw-0005in-Dc for ged-emacs-devel@m.gmane-mx.org; Fri, 12 Mar 2021 11:24:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKkZH-0004Kk-R3 for emacs-devel@gnu.org; Fri, 12 Mar 2021 11:23:15 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:50068) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKkZF-0004PI-GS for emacs-devel@gnu.org; Fri, 12 Mar 2021 11:23:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=csCA+uAz3uMRuQt6hJ0uul34PBjKOyXuofV0Yzyb58A=; b=EmR3qlXLoWDDsWPIQJ5YMVyczc qqMOt7ed4+COotEATn1oElyLkciaKfCJKdT3aFP7Eqdl1PNXSJ44QX0HJGcBAZfvC8XK7WMKXVmo7 xO8kfYjrQYpsCqHs00HDFjcCJF8XD+SluEHtQt1poo8LixbusnvyqL9HZ2WRH8HIhF5c=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKkZ6-00076p-Ng; Fri, 12 Mar 2021 17:23:09 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEWtpqODfoFLQ0b/ //+EeeQSAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UDDBARCMYP7asAAAEzSURBVCjPhdGxboMwEAbg 3yhk6JQhGZqpj2KGZIYII4U5lQpPkUdIqtKhUysVhP+n7PkMKFtvMPq482EfAHau71yIVwDmcLor HLDJ0iyfkLo8tVJabksXHucAzbgAu5vLXAmTLnB2ZWZUR7uNm2BcfbcvRa84OP6iYhO71Rxx5FdE y9GQjCB9Qg0n5RyTUdoDa9Tkm/HsyoDW82KaV/nqVUC/Me0NKDKFNYPAKnhNeLsUaaYNYHjLcyOo 3seAZ6mTzPUbCfMVVoKzzfHkc8TMDx7ggf0CbrH2lxkN0jHcWkGbNvJ+OnXftOE2pUKir8IKXWUm UkWZhWakt5kz/FCsI2hD2TQZ2bUnimpOLd0kBgEf4j/4uGuCtvmcyrpw7mqCpk5hovpv5LDF3K2r OSyQuiH7Ay0C6D/xevVtAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTAzLTEyVDE2OjE3OjA3KzAw OjAwY/uuJwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wMy0xMlQxNjoxNzowNyswMDowMBKmFpsA AAAASUVORK5CYII= X-Now-Playing: Joni Mitchell's _Wild Things Run Fast_: "Man To Man" In-Reply-To: <20210104232349.75BA220CB7@vcs0.savannah.gnu.org> (Stefan Monnier's message of "Mon, 4 Jan 2021 18:23:48 -0500 (EST)") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266406 Archived-At: monnier@iro.umontreal.ca (Stefan Monnier) writes: > * lisp/filesets.el: Use lexical-binding A new warning popped up recently (I think) -- but this patch is almost two months old, so I'm not sure it's relevant or not. Anyway: In filesets-cmd-isearch-getargs: filesets.el:1627:17: Warning: global/dynamic var `files' lacks a prefix And indeed: (defun filesets-cmd-isearch-getargs () "Get arguments for `multi-isearch-files' and `multi-isearch-files-regexp'." (and (boundp 'files) (list files))) Now, filesets.el is a twisty maze of functions, but this seems to be called via the `filesets-commands' alist, and `filesets-cmd-get-def' which is called from `filesets-cmd-get-fn', which is called from `filesets-run-cmd'. Which binds `files' lexically, but is probably what `filesets-cmd-isearch-getargs' is trying to access? I'm not really confident about that analysis, though... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no