Re: master 80e2647: * lisp/filesets.el: Use lexical-binding

Re: master 80e2647: * lisp/filesets.el: Use lexical-binding

[Lars Ingebrigtsen]

monnier@iro.umontreal.ca (Stefan Monnier) writes:

>     * lisp/filesets.el: Use lexical-binding

A new warning popped up recently (I think) -- but this patch is almost
two months old, so I'm not sure it's relevant or not.  Anyway:

In filesets-cmd-isearch-getargs:
filesets.el:1627:17: Warning: global/dynamic var `files' lacks a prefix

And indeed:

(defun filesets-cmd-isearch-getargs ()
  "Get arguments for `multi-isearch-files' and `multi-isearch-files-regexp'."
  (and (boundp 'files) (list files)))

Now, filesets.el is a twisty maze of functions, but this seems to be
called via the `filesets-commands' alist, and `filesets-cmd-get-def'
which is called from `filesets-cmd-get-fn', which is called from
`filesets-run-cmd'.  Which binds `files' lexically, but is probably what
`filesets-cmd-isearch-getargs' is trying to access?

I'm not really confident about that analysis, though...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 80e2647: * lisp/filesets.el: Use lexical-binding

[Stefan Monnier]

> Now, filesets.el is a twisty maze of functions, but this seems to be
> called via the `filesets-commands' alist, and `filesets-cmd-get-def'
> which is called from `filesets-cmd-get-fn', which is called from
> `filesets-run-cmd'.  Which binds `files' lexically, but is probably what
> `filesets-cmd-isearch-getargs' is trying to access?
>
> I'm not really confident about that analysis, though...

Ah the wonderful world of dynamic scoping ;-)
I agree with your analysis and pushed a patch that presumes you
were right.


        Stefan