unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: emacs-devel@gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: master 80e2647: * lisp/filesets.el: Use lexical-binding
Date: Fri, 12 Mar 2021 17:23:03 +0100	[thread overview]
Message-ID: <87h7lguys8.fsf@gnus.org> (raw)
In-Reply-To: <20210104232349.75BA220CB7@vcs0.savannah.gnu.org> (Stefan Monnier's message of "Mon, 4 Jan 2021 18:23:48 -0500 (EST)")

monnier@iro.umontreal.ca (Stefan Monnier) writes:

>     * lisp/filesets.el: Use lexical-binding

A new warning popped up recently (I think) -- but this patch is almost
two months old, so I'm not sure it's relevant or not.  Anyway:

In filesets-cmd-isearch-getargs:
filesets.el:1627:17: Warning: global/dynamic var `files' lacks a prefix

And indeed:

(defun filesets-cmd-isearch-getargs ()
  "Get arguments for `multi-isearch-files' and `multi-isearch-files-regexp'."
  (and (boundp 'files) (list files)))

Now, filesets.el is a twisty maze of functions, but this seems to be
called via the `filesets-commands' alist, and `filesets-cmd-get-def'
which is called from `filesets-cmd-get-fn', which is called from
`filesets-run-cmd'.  Which binds `files' lexically, but is probably what
`filesets-cmd-isearch-getargs' is trying to access?

I'm not really confident about that analysis, though...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



       reply	other threads:[~2021-03-12 16:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210104232347.21177.41247@vcs0.savannah.gnu.org>
     [not found] ` <20210104232349.75BA220CB7@vcs0.savannah.gnu.org>
2021-03-12 16:23   ` Lars Ingebrigtsen [this message]
2021-03-12 16:59     ` master 80e2647: * lisp/filesets.el: Use lexical-binding Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7lguys8.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).