From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Detecting changes between dark and light mode on Mac OS Date: Sun, 21 Mar 2021 08:01:31 +0100 Message-ID: <87h7l5j8hg.fsf@gnus.org> References: <345983B0-C75E-46FF-870C-5FBD3D7381B9@nonceword.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12024"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Daphne Preston-Kendal Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 21 08:02:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNs6N-00032m-T9 for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Mar 2021 08:02:19 +0100 Original-Received: from localhost ([::1]:57964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNs6M-00005J-Tx for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Mar 2021 03:02:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNs5n-00086S-3p for emacs-devel@gnu.org; Sun, 21 Mar 2021 03:01:43 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:46916) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNs5k-00035O-A9 for emacs-devel@gnu.org; Sun, 21 Mar 2021 03:01:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DaqkF2J+/jWrPoXnIdhygaXIZK0R/9gF8ipzgh5Ros8=; b=en0qfvVOTKdmd/sm1AHJB6sUF1 wNVT6edqU2jqf0xzrOnc+NnRGGTulC9/Un8We3ufb7kMqZXdkxG9WcldoqvPgJF4BNkU/LMWG+jJo es4r/I5RINsYE80+RrCt1BxSYYVHqjGp1O2YZRD3waeEYO0aG2TY0NV5OKPLgyfMO0ck=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNs5c-0005W9-Qb; Sun, 21 Mar 2021 08:01:37 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEVZV1NjXlllYVzf V0bziUk/Pzz///+MxlqtAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+UDFQYiDu696nkAAAGwSURBVDjL jVNLdoMwDJRDu7dED4DgAlD5Agm+/5k6kjEhaRfVy0uEx/ORcYiIMvP8UjJzpqO7ls4s0xUw++4Q GMysobSYV2cB6K3ZFZmID/3FrogGIBfC4cMnY7FSUY4oYs1KzJf1QBqlSYlZrScSeYlV3ACEkCw7 KBDTiItEZVc508HEPUTRV+3ndGj55OjLJhGPZ5WwjyMZ0Uo7F4A6AtAAPDtOLOJriMkJgCAiSAlE F2tSg9kmczdnp8QcbgEl2HJ7S8q2sQNIzsLxwRkofpcAsmfCTlEVLLvN+K0N2EJc411CU0ZMBSmf bg4HRMCcwmNICY6DvdQT+UHwsJ6ANO+2ozNKbY/CvZbVr8/QgbPyMmV6A5qWOZCH+s4YLEMq/QLy YrjplFJtcVNbpsT7RvEfKMccBwCl1QHOpWKe7P8S355zsdyAr3r3JYqvBOmw8Lz1gY1wi400NAuQ b3UPgDw8QWltjASTyQGOx1tXgu5Q74l6fewHwQXK/gSKnS3lsU69v+35CVAqj96OK11rrP15o9ey Q4Hf1gm3MdM544sYLhHeNf2uhKv91/q/6/MHY+1qejR7f8UAAAAldEVYdGRhdGU6Y3JlYXRlADIw MjEtMDMtMjFUMDY6MzQ6MTQrMDA6MDDKv7jmAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTAzLTIx VDA2OjM0OjE0KzAwOjAwu+IAWgAAAABJRU5ErkJggg== X-Now-Playing: Autechre's _Sign_: "r cazt" In-Reply-To: <345983B0-C75E-46FF-870C-5FBD3D7381B9@nonceword.org> (Daphne Preston-Kendal's message of "Sat, 20 Mar 2021 17:51:26 +0100") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266686 Archived-At: Daphne Preston-Kendal writes: > Not to pester, more to enquire: I submitted this patch nearly two > weeks ago and still haven=E2=80=99t heard any feedback. [...] > Is there a better place than this to send it to get the attention of > the people who work on Cocoa Emacs and can help more directly with > this question? Should I just send it directly to > bug-gnu-emacs@gnu.org? Sorry about the lack of feedback here -- yes, in general, it's better to send patches to the issue tracker (i.e., bug-gnu-emacs@gnu.org) than to emacs-devel, because patches have a tendency to get lost on emacs-devel. I'm don't use Macos much myself, so I can't really comment on the Macos-specific parts of the patch, but: > + DEFSYM (Qns_dark_mode_changed_hook, "ns-dark-mode-changed-hook"); > + > + DEFVAR_LISP ("ns-dark-mode-changed-hook", Vns_dark_mode_changed_hook, > + doc: /* Hook run when the Mac OS system-wide UI theme cha= nges from dark to light or vice versa. */); > + In Emacs, we generally don't add features that work on non-free operating systems only. So this should instead be a general `dark-mode-changed-hook' feature, with a specific implementation on GNU/Linux, Macos, etc. And we should definitely have a feature in Emacs to respond to dark-mode changes across the board. I seem to recall there being some discussion about this in the past, but I can't find it now. Does anybody remember where that went? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no