From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Lazy wdired preprocessing Date: Fri, 26 Mar 2021 04:27:36 +0100 Message-ID: <87h7kyh9w7.fsf@web.de> References: <87wntuzv7m.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40470"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: emacs-devel@gnu.org Cancel-Lock: sha1:tp3JxRDoisWsiWByV2JH1vMWGiw= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 26 04:28:48 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPd9T-000AQg-Om for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 04:28:47 +0100 Original-Received: from localhost ([::1]:57068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPd9S-0002Nn-RE for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Mar 2021 23:28:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPd8U-0001uj-Dk for emacs-devel@gnu.org; Thu, 25 Mar 2021 23:27:46 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:53516) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPd8Q-000219-WB for emacs-devel@gnu.org; Thu, 25 Mar 2021 23:27:46 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lPd8O-00098z-RC for emacs-devel@gnu.org; Fri, 26 Mar 2021 04:27:40 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267056 Archived-At: Arthur Miller writes: > This was re-implementation of parts of wdired to make it more efficient > and faster to enter the wdired mode. Ok, thanks for the elaboration. Didn't try it yet, but I welcome this change. So far I have one question: + ;; find one column with permissions and set permision text boundaries + (save-excursion + (goto-char (point-min)) + (unless (re-search-forward dired-re-perms nil t 1) + (wdired-abort-changes) + (error "No files to be renamed - Exiting to Dired mode.")) + (goto-char (match-beginning 0)) + (setq-local wdired-perm-beg (current-column)) + (goto-char (match-end 0)) + (setq-local wdired-perm-end (current-column))) Did you check that this works when `dired-hide-details-mode' is enabled? I ask because AFAIK `current-column' doesn't count invisible characters. [It might be better to just count characters from the line's beginning, but I see that the existing code also uses `current-column'.] Thanks, Michael.