Re: [PATCH] icomplete-vertical

[Philip Kaludercic <philipk@posteo.net>]

Gregory Heytings <gregory@heytings.org> writes:

> +;;;###autoload
> +(define-minor-mode icomplete-vertical-mode
> +  "Toggle incremental minibuffer completion with vertical display.
> +
> +This global minor mode is identical to `icomplete-mode' (which see),
> +except that it displays the list of completions candidates vertically.
> +
> +As many completion candidates as possible are displayed, depending on
> +the value of `max-mini-window-height'."
> +  :global t :group 'icomplete
> +  (remove-hook 'icomplete-minibuffer-setup-hook
> +               #'icomplete-vertical-minibuffer-setup)
> +  (advice-remove 'icomplete-completions
> +                 #'icomplete-vertical-reformat-completions)
> +  (icomplete-mode -1)
> +  (when icomplete-vertical-mode
> +    (icomplete-mode 1)
> +    (setq icomplete-separator "\n")
> +    (setq icomplete-hide-common-prefix nil)
> +    ;; ask `icomplete-completions' to return enough completions candidates
> +    (setq icomplete-prospects-height 25)
> +    (add-hook 'icomplete-minibuffer-setup-hook
> +              #'icomplete-vertical-minibuffer-setup)
> +    (advice-add 'icomplete-completions
> +                :filter-return #'icomplete-vertical-reformat-completions)))
> +

Why is this a patch that uses advice and hook instead of a user option
that changes the behaviour of icomplete directly?

-- 
	Philip K.