From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Mon, 03 May 2021 07:30:04 +0200 Message-ID: <87h7jk75b7.fsf@gmail.com> References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <20210403001539.x4rb55dvh46rmhb3@Ergus> <2599ffef-4f70-025c-5f9c-61b9ac94faf8@inventati.org> <87eefrbo9k.fsf@posteo.net> <7473b27b2b479f5686af@heytings.org> <87tuon9vf1.fsf@posteo.net> <20210403174508.xwr5uc36dzityitn@Ergus> <87wnsurdr7.fsf@gmail.com> <87fszij6to.fsf@mail.linkov.net> <87v98asulc.fsf@gmail.com> <87pmyimiwd.fsf@mail.linkov.net> <87bla11u5q.fsf@gmail.com> <87lf937hgk.fsf@mail.linkov.net> <87y2d1ksga.fsf@mail.linkov.net> <87r1it7zfw.fsf@gmail.com> <87v98466it.fsf@mail.linkov.net> <87bl9wcksv.fsf@gmail.com> <87tunnzqci.fsf@mail.linkov.net> <87bl9tmzun.fsf@gmail.com> <87y2cwhiti.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17245"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: Philip Kaludercic , Gregory Heytings , Ergus , Manuel Uberti , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 03 07:42:53 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldRM4-0004M1-0l for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 07:42:52 +0200 Original-Received: from localhost ([::1]:56904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldRM3-0008J2-45 for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 01:42:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldR9m-0001lF-HW for emacs-devel@gnu.org; Mon, 03 May 2021 01:30:10 -0400 Original-Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]:44644) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldR9k-00006E-GO for emacs-devel@gnu.org; Mon, 03 May 2021 01:30:10 -0400 Original-Received: by mail-ej1-x629.google.com with SMTP id gx5so5999210ejb.11 for ; Sun, 02 May 2021 22:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=LjqihGs1mxmlfWvNjvqLHohyNSDP4i1khS9Sl3LwAAs=; b=pou05Y4ZkJQ6x2lA4lcrROYZYcok/D4vwDMbATRkVq7KZ0wcus6JdM9YuhdOhDdLXg RiLIIQ7kP7X1Ezka/aGCIm/g1xkgGCzg7FRm9NQ+IbN7Jva18LlWzCVXQLrtpV+yYO5R I8Tz1aOkqRO4FgkU1lHpYy1qFxvvhfrsgWzBXjqL5Wv82b6GWwiNmzxdgqORbzcUh4+3 GzYn1jia9xtUa+l7nD4ucTwrMrsH3m9bAAwzLsp12CDEJb8LO8QBPAbBZd1besYYxdTf G9Pyi+kHosmp4SZJFfM0QNt9k/0uKJzJB7yozTQvec8UoS56Ewlv5Uxc205qQwikk7G1 6yxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=LjqihGs1mxmlfWvNjvqLHohyNSDP4i1khS9Sl3LwAAs=; b=N19xCTyD09u/CAm5g4cvzfh/DykCv4kymUg2vJpmSQdzNQWktDnbwW0PpxyKCAR4Oa Lv8PmtIoqDOq2Yc8NtjhcKRuGekKsjLz2z7SWPPiNNFRr7YwtjUuGQ6Y9NvECKXS8vvV 2QH5mEinz/cjJKSQg7SKPIVWbp+StIChTh0YNi5WHpLLt+f8NhN1DMGqv4ZS3HGf6Yao OkYUMSQ15o3OVfMR7bpU2xuHtEHVrEMRyUA5W1P9wkB9/dFFO2W+TNdzxxRY0GJxrkaP a088kO64oO/W1cv4YirqQJzV+yzvKenqVWrI1NQC/efi2aMfi6YelwxbtHMTvsbV5Pmv IBag== X-Gm-Message-State: AOAM531ZP687wupMiAB88pDa1MPzRGwiry9Emm4qtTkH1bn96TTmzX6Z XptQvrrml5d163jf0jcqhuc= X-Google-Smtp-Source: ABdhPJybs33lDzIRwtFDC/dUMSRX237lmx1cM79wMtvdhK2Bm92SYFFkFt8j45biSPH+yGSjd0Q1OA== X-Received: by 2002:a17:907:948d:: with SMTP id dm13mr14784946ejc.180.1620019806283; Sun, 02 May 2021 22:30:06 -0700 (PDT) Original-Received: from ars3 ([2a02:908:2211:8540::68a]) by smtp.gmail.com with ESMTPSA id t22sm11679995edw.29.2021.05.02.22.30.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 May 2021 22:30:05 -0700 (PDT) In-Reply-To: <87y2cwhiti.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 03 May 2021 01:18:09 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::629; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268798 Archived-At: On Mon, 3 May 2021 at 01:18, Juri Linkov wrote: >> 1. Since you probably want to remove the ugly `with-isearch-suspended' >> eventually, the local mode will not only be on by default, it will be >> the only alternative. Should then `isearch-buffer-local' be >> double-dashed, so it too can be removed? > > It could be removed in later releases, indeed. But OTOH, until > it's removed, naming a user option with double-dashes is not allowed. > >> 2. In edit mode, when I delete a character, the search doesn't backtrack >> to the barrier. It's the same undesirable behavior described in >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=46469. In isearch-mb, >> the post-command-hook contains >> >> (goto-char isearch-barrier) >> (setq isearch-adjusted t isearch-success t) >> >> for to fix that. > > Thanks, this should be added to the patch. > >> 3. The after change hook should call `isearch-update' instead of >> `isearch-search-and-update' after `previous-history-element' and few >> other commands. In isearch-mb I use a symbol property to keep track >> of this. > > Thanks, it seems many solutions could be taken from isearch-mb to > isearch.el. Actually, since I thought this thing through already, I would be happy to provide a patch implementing the minibuffer-controlled isearch. May I suggest that you merge just the `isearch-buffer-local' change at this point, and then wait for my patch doing the minibuffer part? > >> 4. Every time one types a character in the minibuffer, there is a >> visible flicker in the cursor. In isearch-mb I've let-bound >> `inhibit-redisplay' to t in a couple of places and it solved this >> problem. I wonder if there's a better solution. > > Maybe a flicker is caused by isearch-message? That's not it, since isearch-mb overrides `isearch-message' completely, and still requires inhibiting the redisplay. It seems to be related to selecting a different window. > >> 5. The command `isearch-forward-exit-minibuffer' should eventually be >> removed, and instead `isearch-repeat-forward' should work in both >> cases (this will probably be implemented with the help of a new >> macro). The reason for this is that there is at least a dozen other >> Isearch commands that make sense in the minibuffer map as well >> (toggling modes, quitting and entering query-replace, and so on), and >> it would be annoying to write a minibuffer variant for each of them. > > This is the part where I don't yet have an idea how to handle > all isearch commands from the minibuffer without using a macro > to implement their duplicates to be callable from the minibuffer. I don't think there's another way. Do you see this as a big problem? > >> 6. Why is there the option to specify an `isearch-new-message' in >> `with-isearch-suspended'? I've never seen any valid value other than >> `(mapconcat 'isearch-text-char-description isearch-string "")', which, >> by the way, repeats at several places in isearch.el > > This is just to handle existing uses of with-isearch-suspended that > currently set isearch-new-message, i.e. this could be changed later. Actually, in the patch attached to https://lists.gnu.org/archive/html/emacs-devel/2021-04/msg01359.html (which by the way, do you think we can merge it?) I added an `isearch-set-string' function to encapsulate this. This function would be useful to implement the minibuffer-controlled mode, as well as for third-party packages and user tweaks. > >>> And here is a patch for updating the search from the minibuffer. This allows >>> to implement https://lists.gnu.org/archive/html/emacs-devel/2020-01/msg00447.html >>> to control the search from the minibuffer. But I'm not sure if the same option >>> isearch-buffer-local should enable this mode: >> >> I still don't understand why Isearch has to be so stringent about >> backward compatibility of key sequences. But I don't care about the >> edit mode per se. I only care about an alternative mode where `C-s' >> immediately goes to the minibuffer, and exiting the minibuffer ends the >> search. > > In such a new mode isearch-edit-string could be called at the end of > isearch-mode. True. `RET' and `C-g', among a few other things, should behave differently in the two cases, but that's a detail.