From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [External] : Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Sun, 09 May 2021 13:37:52 -0500 Message-ID: <87h7jboirj.fsf@red-bean.com> References: <87a6pcqy7s.fsf@red-bean.com> <83czu86o46.fsf@gnu.org> <835z006jpl.fsf@gnu.org> <87im3z3f8f.fsf@red-bean.com> <83zgxb67g2.fsf@gnu.org> <87mtt9sqh4.fsf@red-bean.com> <87czu58uso.fsf@gnus.org> <878s4tq8e6.fsf@red-bean.com> <874kfguail.fsf@red-bean.com> <875yzwtkuj.fsf@gmail.com> <87lf8prm2f.fsf@gmail.com> <83eeeg8ez9.fsf@gnu.org> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3504"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: larsi@gnus.org, Matthias Meulien , monnier@iro.umontreal.ca, drew.adams@oracle.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 09 20:39:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfoLF-0000ml-CB for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 20:39:49 +0200 Original-Received: from localhost ([::1]:38508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfoLE-00073a-6y for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 14:39:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfoJj-0005dl-Rw for emacs-devel@gnu.org; Sun, 09 May 2021 14:38:16 -0400 Original-Received: from sanpietro.red-bean.com ([45.79.25.59]:51378) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfoJa-0003F0-FQ; Sun, 09 May 2021 14:38:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Reply-To:References:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=j6XbI9O1rRCVmpheNIzbaIkdMQHqa3ITnsC//rswByQ=; t=1620585484; x=1621795084; b=hOxW2WaMIWUHHulNPx+jRXm9WBcQF3r0T2orSuX67/ZahjTsFpwxLkMAnTiJTCExNDeEScbgIm w3dnJZh2EVorDfnR9qOK6ElABpaVdCN1xi1sM6PXuOuYNEobsEe5TRFcm/oQAJdNtoF86wUeTfulj a7G1rTg4gUhtDK4e4reIEor0JDeH+TUs98QNP2i0JpUG4aPYp5rp2JapzjN/SldIbODvoH2Q6tZl4 8eHRSPybdvIwN5d0Vacm9fmASxLm2YN4f8jOXraztMNlrlLZTSq2eslwnELEKt+X5V+SYtqzNMLM7 TdDYkLCX/xT/F3a51XBLCcg6pugrwL66K5wxA==; Original-Received: from [2601:240:cf81:9740::7720] (port=45096 helo=klen) by sanpietro.red-bean.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfoJN-0002Id-F1; Sun, 09 May 2021 18:37:53 +0000 In-Reply-To: <83eeeg8ez9.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 09 May 2021 11:54:02 +0300") Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269089 Archived-At: On 09 May 2021, Eli Zaretskii wrote: >> Should the docstring of `bookmark-bmenu-load' should be >> extended as >> follows to make this feature easier to discover? > >Yes. However, this works because bookmark-bmenu-load calls >bookmark-load via call-interactively, and the latter is sensitive >to >the prefix argument. So the doc string of bookmark-load should >also >be improved by mentioning the effect of the prefix argument. My inclination would be to do this by having `bookmark-bmenu-load' just refer readers to `bookmark-load', and then improving the latter's doc string. That way if future changes are made to `bookmark-load's behavior, we wouldn't need to remember to update `bookmark-bmenu-load's doc string too. Thoughts? Best regards, -Karl