From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [WIP PATCH] Controlling Isearch from the minibuffer Date: Tue, 11 May 2021 00:17:09 +0300 Organization: LINKOV.NET Message-ID: <87h7jath3m.fsf@mail.linkov.net> References: <87zgx5cz33.fsf@gmail.com> <87o8djohqf.fsf@mail.linkov.net> <87eeeenxqq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4067"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Augusto Stoffel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 10 23:33:35 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgDWx-0000w9-Dd for ged-emacs-devel@m.gmane-mx.org; Mon, 10 May 2021 23:33:35 +0200 Original-Received: from localhost ([::1]:59330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgDWw-0005Uu-0C for ged-emacs-devel@m.gmane-mx.org; Mon, 10 May 2021 17:33:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgDSH-0008UF-Pc for emacs-devel@gnu.org; Mon, 10 May 2021 17:28:45 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:54819) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgDSG-0005bB-54 for emacs-devel@gnu.org; Mon, 10 May 2021 17:28:45 -0400 X-Originating-IP: 91.129.102.166 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id BFC521C0006; Mon, 10 May 2021 21:28:41 +0000 (UTC) In-Reply-To: <87eeeenxqq.fsf@gmail.com> (Augusto Stoffel's message of "Mon, 10 May 2021 22:24:13 +0200") Received-SPF: pass client-ip=217.70.183.197; envelope-from=juri@linkov.net; helo=relay5-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269136 Archived-At: >> You can avoid the timer hack by adding a guard to >> isearch-post-command-hook: when at the end of the isearch command, >> point is not in the minibuffer, activate the minibuffer >> (assuming that isearch-from-minibuffer is t). > > That didn't work well, because when canceling a command called from the > post-command hook one gets an ugly error message. How do yo cancel such a command? > I hope this is a guideline rather than an axiom, so let me describe what > the *slight* incompatible changes are: > > 1. The user is forced to see lazy highlight and lazy count while editing > the search string via M-e, as long as these options are already > enabled globally. Why not enable these incompatible changes only when isearch-from-minibuffer is t? > 2. A M-s prefix is added to minibuffer-local-isearch-map, as well as a > few extra commands (M->, M-<, etc.) The users might want to use M-< M-> to go to the beginning/end of the minibuffer. > 3. and C-f are unbound. Removing and C-f is a very good thing, indeed. >> The with-isearch-window-quitting-edit macro can be avoided the same way >> as the with-isearch-window macro. > > I'm not sure this is possible. Is there a way to get rid of the > minibuffer without returning control to the caller of > `read-from-minibuffer'? I couldn't find a way to do this, hence the > throw/catch of a continuation function in the current version of the > patch. Why not return control to the caller with `exit-minibuffer'? When still necessary, you could try `exit-recursive-edit'.