unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 28bf387: Tweak Fdirectory_append for efficiency
Date: Sun, 25 Jul 2021 08:38:02 +0200	[thread overview]
Message-ID: <87h7gizynp.fsf@gnus.org> (raw)
In-Reply-To: <83r1fny6s4.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Jul 2021 20:13:15 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> You should indeed be able to do that, that's my case #2.  The case
> that doesn't have to work and doesn't make sense is this
>
>   (multibyte-string-p (encode-coding-string "bár" 'latin-1))
>   => nil
>
>   (multibyte-string-p "/tmp/bár")
>   => t
>
>   (directory-append "/tmp/bár" (encode-coding-string "bár" 'latin-1))
>   => "/tmp/b\303\241r/b\341r"

The function isn't really concerned with charsets -- that's an
orthogonal issue.

The user may well have a unibyte string that contains non-ASCII octets
(note -- not characters), and I see no reason why a string concatenating
function should refuse to handle those.  It's up to the caller.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2021-07-25  6:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-24 16:27 master 28bf387: Tweak Fdirectory_append for efficiency Eli Zaretskii
2021-07-24 16:29 ` Lars Ingebrigtsen
2021-07-24 16:36   ` Eli Zaretskii
2021-07-24 16:49     ` Lars Ingebrigtsen
2021-07-24 16:58       ` Eli Zaretskii
2021-07-24 17:05         ` Lars Ingebrigtsen
2021-07-24 17:13           ` Eli Zaretskii
2021-07-25  6:38             ` Lars Ingebrigtsen [this message]
2021-07-25  7:08               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7gizynp.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).