From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Making `replace-match' more efficient
Date: Thu, 07 Oct 2021 20:56:28 +0200 [thread overview]
Message-ID: <87h7dsslyb.fsf@gnus.org> (raw)
In-Reply-To: <83h7dszmv3.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Oct 2021 21:54:56 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> + if (SBYTES (string) == SCHARS (string)
>> + && SBYTES (newtext) == SCHARS (newtext)
>
> This is not enough to detect pure-ASCII strings, because such strings
> are many times unibyte. Perhaps this is one reason why you didn't see
> any significant performance gains.
It was just an exploratory patch. I confirmed that this branch was
taken in my tests.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2021-10-07 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 18:33 Making `replace-match' more efficient Lars Ingebrigtsen
2021-10-07 18:54 ` Eli Zaretskii
2021-10-07 18:56 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7dsslyb.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).