From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 291085a2a6: (Fmake_finalizer): Check the arg is a function Date: Fri, 31 Dec 2021 13:24:02 +0100 Message-ID: <87h7apdkt9.fsf@gmx.de> References: <164092777246.5319.12726126534253040404@vcs2.savannah.gnu.org> <20211231051612.BC467C002EE@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12847"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 31 13:25:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n3Gyj-0003A8-CL for ged-emacs-devel@m.gmane-mx.org; Fri, 31 Dec 2021 13:25:49 +0100 Original-Received: from localhost ([::1]:56636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n3Gyi-0003Qk-3N for ged-emacs-devel@m.gmane-mx.org; Fri, 31 Dec 2021 07:25:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3Gx9-0002So-Q5 for emacs-devel@gnu.org; Fri, 31 Dec 2021 07:24:11 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:49605) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3Gx6-0000we-Oo for emacs-devel@gnu.org; Fri, 31 Dec 2021 07:24:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1640953444; bh=BZV8dNTrVP6EeLMGUNJV7qVawyxUL76XeIRUq8EltjI=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=BaG3rGW5IzzR7X/q8SWV50sAdI5+S/23u8Dltyrg5ADIbeirNr7Aa+fG1LAUAR8An yGd+ZUjm962qOHuHuAjj4DMJVBwiCCm71TTlg7PIGgMV8in242hzsdsT1tyYXwxdhC 0aGUE+BN/seudv29fUaJ5FfkYMawEX+SiRBSBBL4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.159.37]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M4s0j-1n1tNE3q1H-001xfW; Fri, 31 Dec 2021 13:24:04 +0100 In-Reply-To: <20211231051612.BC467C002EE@vcs2.savannah.gnu.org> (Stefan Monnier via Mailing list for Emacs changes's message of "Fri, 31 Dec 2021 00:16:12 -0500 (EST)") X-Provags-ID: V03:K1:E76YXjcN6xDtX9VXdsMXRvG5RyeR5A6y3lZBhjbJZ3Hm3OWyCqb 6Cn40gLVorGR7KTCUprNaa69ctM32FeE7znSXomo0hnHLsdr5vB+zP2mJf7o6k6Ma/giBBU jlstOQpFaKanNZvNTysZRMTnsqvXIAz36eKxfejDcXKmKKgh8A2LtUY2lRRpHpnnYFS+P3L I7WhKD99r+iI5K/CrymyQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:UxK0sE2cYS4=:3Peog9SNvY/E7gYYPfNbXF IEYH+nHaVC5TzzxD+EGvudYbO7OHpuosbv7SbSS9hmEWLdnvY3nV9pieB4hekjYoZ0HVlcWFN DLVoWTQlRJJyrNbc/xtml8LY7POiAASvA4KcD56iz+3Pd0PqTGrc6K84053wAVaFqLC1M22Bj CWhCjzop5OXtj8RK0ewgXDJYH8rhXIuFMdKWeKLiyPw+CMEhGRhsXs3f7y9WQf6dLTBcG+Qar kt824u9k+pQy/Y/hJFVUM9NFKfyxGAby4UZjvzQG78IwiSYUrbZpIpQFFgn+EWgKjuqLFVIVl imiZpBIgeSVcPTRYa0E54Kl/P8fTNKJ/s/SD2GLX3Sb607Yu+uCOb/+rv4prUntQs5B5ZEBnd oovo0TSqkYnZoaV4moHTaU+CFjR5v0vcULt+4yvpAKJAn3q30V6JLF0WQz//QAVf0nX46y4Sg qXOJfzjGQqdkY2qtRENEaxv2Qp4bmbldeFAQfj2920+GVupaPPBsW5vCo70qnBzF4373VBGoU 1yxhBPC2U8RgzcD71cr4TkWHJeWVZm2tDBAWGdJrDjKeC+kPBybXSAXdEucEojw5y4MpndnuO FQxjp3Ch6VPv2l6UgdidJCFNmjFEifW75JdXQrgfcTvFPHLOkJ31z3GzPskTFoi7tUqm/kLqj YNs4pwfq/GH9uoQe6oeGVyiBqQxXkbPbmzEv4wa1Eeaw/KySVfXmgYU5Qq2WbSw10BZAJQHlA mKtbNIjV0awwaqwjrUXhnyehud2gZBO2P7jJDzKpYb8Os1R+h6szhPPGADQmdDZHNlcek2U7 Received-SPF: pass client-ip=212.227.15.19; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283735 Archived-At: Stefan Monnier via Mailing list for Emacs changes writes: Hi Stefan, > branch: master > commit 291085a2a61d7596e6f3e3152247198fdf85da26 > Author: Stefan Monnier > Commit: Stefan Monnier > > (Fmake_finalizer): Check the arg is a function > > * src/eval.c (syms_of_eval): Add `Qfunctionp`. > * src/alloc.c (Fmake_finalizer): Check the arg is a function. This fires an error: =2D-8<---------------cut here---------------start------------->8--- $ make -C test alloc-tests make: Entering directory '/usr/local/src/emacs/test' make[1]: Entering directory '/usr/local/src/emacs/test' GEN src/alloc-tests.log Running 5 tests (2021-12-31 13:19:55+0100, selector `(not (or (tag :unstab= le) (tag :nativecomp)))') passed 1/5 aset-nbytes-change (0.000107 sec) Test finalizer-object-type backtrace: signal(wrong-type-argument (functionp nil)) apply(signal (wrong-type-argument (functionp nil))) (setq value-2 (apply fn-0 args-1)) (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-descri (if (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-de (let (form-description-4) (if (unwind-protect (setq value-2 (apply f (let ((value-2 'ert-form-evaluation-aborted-3)) (let (form-descripti (let* ((fn-0 #'equal) (args-1 (condition-case err (let ((signal-hook (closure (t) nil (let* ((fn-0 #'equal) (args-1 (condition-case err ( ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name finalizer-object-type :documentation ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :unstabl ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ":." "-L" "./../../elpa/packages/url-http-ntlm/ command-line() normal-top-level() Test finalizer-object-type condition: (wrong-type-argument functionp nil) FAILED 2/5 finalizer-object-type (0.000099 sec) passed 3/5 record-1 (0.000070 sec) passed 4/5 record-2 (0.000042 sec) passed 5/5 record-3 (0.000050 sec) Ran 5 tests, 4 results as expected, 1 unexpected (2021-12-31 13:19:55+0100= , 0.111531 sec) 1 unexpected results: FAILED finalizer-object-type =2D-8<---------------cut here---------------end--------------->8--- Best regards, Michael.