From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 64109fcae7 2/3: indent-for-tab-command: Deal with large point or modiff values. Date: Mon, 17 Jan 2022 14:38:40 +0100 Message-ID: <87h7a2qy73.fsf@gmail.com> References: <164219059635.16941.2631797019964844711@vcs2.savannah.gnu.org> <20220114200316.CB79BC0DA30@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38208"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philipp Stephani To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 17 15:29:30 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9T0k-0009oX-7e for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Jan 2022 15:29:30 +0100 Original-Received: from localhost ([::1]:38284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9T0i-0006bE-Gu for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Jan 2022 09:29:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9SDg-00071b-IL for emacs-devel@gnu.org; Mon, 17 Jan 2022 08:38:48 -0500 Original-Received: from [2a00:1450:4864:20::329] (port=39795 helo=mail-wm1-x329.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n9SDe-0002dI-IN for emacs-devel@gnu.org; Mon, 17 Jan 2022 08:38:47 -0500 Original-Received: by mail-wm1-x329.google.com with SMTP id d18-20020a05600c251200b0034974323cfaso24416601wma.4 for ; Mon, 17 Jan 2022 05:38:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version; bh=bJpuU+rAQGJSWS2pLgRuEGrbfN2RNb8a6713xTKJmiE=; b=JM5Sb90AhWqDLj3ICMsenu4ugF3vrgN0yoGbM1Bdl8JMspaFKjneZIIX6Z/Frnf6pl hZOJU98GJ4QkPjlMsJ0HaZD9RUrl1G3/PqMpbmUqRgDcgVIKk7cDC3fS+50OpjpItRtY IYGFnocT1Ni+SdCAXOHYGRkKrr5tAlu8T4F0JuoIeB/lkRLyKfBuobGAoBVC02/U+JID VC8twV+GvjSYTa3egNgZQkDUEmDUq6a4uOXHYqFB+OK/kaqECcQ7OE0DkCf2jl3bnSVY V+WfSYBDLvg9uEei9ptimn/KUyMfz7SewBvgRAIMq2LexHelPX1eMRIMWdASWDSh+131 bAcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=bJpuU+rAQGJSWS2pLgRuEGrbfN2RNb8a6713xTKJmiE=; b=s3157FxJiXDE3jEYo7FgLVX1MuvgL5m/bEEq5wbrNLGVjnrJLRDGfK5ZTanY+2AsP2 so5TIklXsIa0QKLj0hvjCGa2dmkcDvzUaFoWTmsdbRZ91usuL7Y9Fkwrs4a/Jmgzdr1/ BdCi0zXyvxmf1xmjX8JZJ6FA5mpta0ncZ5eCLvGcV1JY/KYVuKWozOIvjk6J5o+xEGXD ICT+3fS2hXswpimSN3WLgsQLktU43QJVArw6L7ufgoH2T7qYnXhMP8Yz9NQwYDDAoG8u Yhgq8NEiPct2jb8+0Q5l9ri93rbLYv4DBC6iJcHkCR67RV83TJlGtNNVH3TX7cov4/0+ TTJA== X-Gm-Message-State: AOAM531I4B0sOLe37iUTuQ7i03Ql96W0IVykcYu4PkYE6O03gXBfXG5n XdtSZsF+6d2vOJo0mX6r08g= X-Google-Smtp-Source: ABdhPJwG8Sa+x0DqxkAupTARpdwDSLmm1XuF8CMXHBQTSgekDg8S+bGITAAbEbU2P8a87eIo32NjUw== X-Received: by 2002:a05:600c:6014:: with SMTP id az20mr394044wmb.139.1642426721449; Mon, 17 Jan 2022 05:38:41 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:cb88:72ae:f560:b08c]) by smtp.gmail.com with ESMTPSA id f5sm13451734wmf.47.2022.01.17.05.38.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jan 2022 05:38:40 -0800 (PST) Gmane-Reply-To-List: yes In-Reply-To: <20220114200316.CB79BC0DA30@vcs2.savannah.gnu.org> (Philipp Stephani's message of "Fri, 14 Jan 2022 15:03:16 -0500 (EST)") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::329 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=rpluim@gmail.com; helo=mail-wm1-x329.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284877 Archived-At: >>>>> On Fri, 14 Jan 2022 15:03:16 -0500 (EST), Philipp Stephani said: Philipp> branch: master Philipp> commit 64109fcae710a372bf7690e2da461ab71ca78dcd Philipp> Author: Philipp Stephani Philipp> Commit: Philipp Stephani Philipp> indent-for-tab-command: Deal with large point or modiff values. Philipp> * lisp/indent.el (indent-for-tab-command): Don't use 'eq' to compare Philipp> integers that aren't guaranteed to be fixnums. Philipp> --- Philipp> lisp/indent.el | 4 ++-- Philipp> 1 file changed, 2 insertions(+), 2 deletions(-) Philipp> diff --git a/lisp/indent.el b/lisp/indent.el Philipp> index 8dc4c31f13..ad6fd899c5 100644 Philipp> --- a/lisp/indent.el Philipp> +++ b/lisp/indent.el Philipp> @@ -182,8 +182,8 @@ prefix argument is ignored." Philipp> (cond Philipp> ;; If the text was already indented right, try completion. Philipp> ((and (eq tab-always-indent 'complete) Philipp> - (eq old-point (point)) Philipp> - (eq old-tick (buffer-chars-modified-tick)) Philipp> + (eql old-point (point)) Philipp> + (eql old-tick (buffer-chars-modified-tick)) Philipp> (or (null tab-first-completion) Philipp> (eq last-command this-command) Philipp> (and (equal tab-first-completion 'eol) You could use '=' here, no, just to emphasise the point that these are integers? Robert --