From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master b1e9151: Enable the native display of BMP images on Haiku Date: Sat, 26 Mar 2022 20:33:36 +0800 Message-ID: <87h77k51wf.fsf@yahoo.com> References: <835yo0c2xa.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3921"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 26 13:35:41 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nY5dt-0000t8-79 for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Mar 2022 13:35:41 +0100 Original-Received: from localhost ([::1]:35090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nY5dr-00020h-Q7 for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Mar 2022 08:35:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nY5c6-00016j-Dx for emacs-devel@gnu.org; Sat, 26 Mar 2022 08:33:50 -0400 Original-Received: from sonic313-56.consmr.mail.ne1.yahoo.com ([66.163.185.31]:39647) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nY5c3-000546-Pa for emacs-devel@gnu.org; Sat, 26 Mar 2022 08:33:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648298025; bh=goajD3vRnJXjhzP0WaAvVvvlKpOFtOOU1R50uWcCjhU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=e5Am1lrS34AgHry2DpDvRkpnFviN4gnP5gJfaMCSV19elZD99ahPqe8hPMCtHym4vbEF53s8pp0xaiJuJl9cveEID5zhFtQ5vMNAT8baJZe8UFuvx5BWKG3lJM1rcNw66mTi9QpzFw02AflxHS/fAhhQw/r8ehtac4fBGNtNKGEeW6v81gKEmdJ52sRSp2RQo9GTGBodNteHXTLTcUPOgyJxaXwAV8yZlbW95CDwmL/ZJqCS+r2Kw/8Q/ZNJH1MHajhXvJb/WbLpStDHTe/k105ZPzZO1WYPxNaaX4eM6KKqgj0IPvycrVt1m1IGJxOBcQvNOfKqffLVT10/bAXPZg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648298025; bh=kiaVOss0/nThBK5tJ4JNkKygHd2I7A+peRdz9+iZE5R=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=LYd78ae10k8Pp9ocqWlwZrkUOOZlnrkYzF6HtbSZPov7jVH2kUulLRT9b75bWz5/jy3VHG8rXT5GcWlKBwQ851jD0807NpOqlz5f8mZa0FsLBotN3N3053ifH9M7lRTk8yhPo3Zl9d9nEr7RfMYzaV16pEUfswTaTx3WQCGOw/TF5Ku7xLG7E1ie34+HtYzn4uDROCd++s5RWmHnDuUiUQ//p0/kzWxCJT2NDu9QFifhRFz8YS/JkQHYFN7zN0EKEEgnx5Y39sXka9j3N4Q80D68OrBPDOICy2yI2ajHHlDGcKsbd3tOgJ27LMZI4qojmMhrxCdPWB/DGVZ2iKssnw== X-YMail-OSG: Z8CEGiAVM1miFsPv2K9JIzOJ9hVNv81Mo7yNyUoK.7UtKielfh28nNRHkdt73d_ hvuI8kKLYMCusG24xlO7dAdyZWWusJE5Z1ypiO0202Wj9WBqNcM3xtVxt0bCe9DaqvptKbORM8MO JzI2ppjL4.OR7uIh_AcLzOeVPnSGzpvD8Ajg3Ja8asvW8Ryzvf_clNpHyvk2hK2CwRKmWJ3viKlg bJRySc1Bp1jzXK55ixc7970fzVaDW_PxcQuehCTPSko7YHOUuRkiWu4BU6WYUHu9VwiaHvgPDkvW x3iySGlBLOXYJMDzDz8mQy_bYW80uZF0B6yxGfrRysf3Xyu1KVYSMXi1xYogbJnCtNvFK4u_8Bd4 SmGpg7MgMe4aOnLxD7WAN5iRiuR_kchLhkw9CcljjazIMj7rh_vaEeBEeGw_ESZgeRKnE6logIiv 6Nc5z5PoK3.gzvKuclIun0yxH8Y_f9OdbcZWIiDx0GP4QnhCQ0XmuTX.1.GmmR95DyrQQoQSv7Si 5eqNTjogX3hKJT6NMvPmn_icnxmqf3COV14tfCERnWQ_SpY8ucOOQQBp4HQK676I76hi1Lv6pxPw q7jXxddwIXuz3DzX9o4bbLGPjVfo5_5BAegWzIurXOLuA78CEnqVZZhNXKNwXWuE7L7uSlx5.2hn TrxBiBpixzBJMyKZLMYS8IwQDGm8KiOiJqP8etTiOqn8HZOpJIgel9Mvo5mc2mFOa32UH9xPpav8 bu2NYAF4OmmRp7CtWyOcnjzFIXhwZI_Q6Tbd3L4MTu8qx6cUuD.g0EBIbMvrOi52hR_ZTtU8.nlM ZnOJN31qP5cWv8lNywHr4MopWM8UE36ym.sMgr45iD X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Sat, 26 Mar 2022 12:33:45 +0000 Original-Received: by kubenode519.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 7c6c58ae7aa3f1df9aa295c0931ffeae; Sat, 26 Mar 2022 12:33:41 +0000 (UTC) In-Reply-To: <835yo0c2xa.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 26 Mar 2022 15:29:37 +0300") X-Mailer: WebService/1.1.19987 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.185.31; envelope-from=luangruo@yahoo.com; helo=sonic313-56.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287477 Archived-At: Eli Zaretskii writes: >> --- a/src/image.c >> +++ b/src/image.c >> @@ -11555,12 +11555,16 @@ syms_of_image (void) >> >> #if HAVE_NATIVE_IMAGE_API >> DEFSYM (Qnative_image, "native-image"); >> -# ifdef HAVE_NTGUI >> - DEFSYM (Qgdiplus, "gdiplus"); >> - DEFSYM (Qshlwapi, "shlwapi"); >> + >> +#if defined HAVE_NTGUI || defined HAVE_HAIKU >> DEFSYM (Qbmp, "bmp"); >> add_image_type (Qbmp); >> -# endif >> +#endif >> + >> +#ifdef HAVE_NTGUI >> + DEFSYM (Qgdiplus, "gdiplus"); >> + DEFSYM (Qshlwapi, "shlwapi"); >> +#endif >> #endif >> >> defsubr (&Sinit_image_library); > Shouldn't you now remove SEFSYM for Qbmp from haikuimage.c? Probably, but it doesn't hurt to keep multiple DEFSYMs around right? Thanks.