From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James N. V. Cash Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Handle case where `beg` and `end` are strings instead of markers Date: Thu, 28 Apr 2022 21:10:32 -0400 Message-ID: <87h76c4ruf.fsf@occasionallycogent.com> References: <87k0b84tfr.fsf@occasionallycogent.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33687"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 29 03:11:15 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkFAB-0008cp-Cv for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 03:11:15 +0200 Original-Received: from localhost ([::1]:35522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkFA9-0000x6-Uc for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Apr 2022 21:11:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkF9Y-0000Dz-QP for emacs-devel@gnu.org; Thu, 28 Apr 2022 21:10:36 -0400 Original-Received: from mail-qk1-f179.google.com ([209.85.222.179]:42531) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nkF9X-00078a-Fd for emacs-devel@gnu.org; Thu, 28 Apr 2022 21:10:36 -0400 Original-Received: by mail-qk1-f179.google.com with SMTP id j6so4904665qkp.9 for ; Thu, 28 Apr 2022 18:10:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=gtqCO5BKuLwe8vpZEuK68BxPI7Tq/15j+OFe8sTd8sg=; b=Y+LL7ROjB3G42z2f+B+u7kwaKiCnaDKgtWnOWda+9azMXNI8lW0A5EgOT9AHVVn95S osQdtKjV2jlkj1cplIOpboBBmp4jiA4cy03XxmMfCivSvVIeZiPfnPSmCXP8JDqHw3OB lftFkzyq2hAUnUcWGzDZqbfStZafXTKgvQtzV2f7WBza+KBpCWzpycetSATT66gQppiI ryXvtQrDMvnxnyN4UmHrjknUHuKozkOxGO88WUsnh6YTVl82ArdYcScLcv7hPE9eRXIY IKQvRlt8SiRE7MPiEA2tCCukjbM0exuyyvaie1nuejKbtY0ObgBSaRJ89h/qO+aiOtph oy1Q== X-Gm-Message-State: AOAM532EcMbNwN/CRmyzsgAkKIclL6E6J0cTqGhaVgtnbe3aastuhGHJ nwhDOkkeO94bWlHLGrUzTH2VlHtjDiI= X-Google-Smtp-Source: ABdhPJwz+TLrOljv9rezG4KZU9ofgh9NW+NKpimbr2kynK27pSwA6s0QORADGpHcuDYr8w5jLAWxRQ== X-Received: by 2002:a05:620a:e88:b0:69f:9e4a:9e74 with SMTP id w8-20020a05620a0e8800b0069f9e4a9e74mr4326495qkm.341.1651194634393; Thu, 28 Apr 2022 18:10:34 -0700 (PDT) Original-Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com. [66.111.4.228]) by smtp.gmail.com with ESMTPSA id s12-20020a05622a018c00b002f2017d5652sm901444qtw.40.2022.04.28.18.10.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 18:10:34 -0700 (PDT) Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id B4F3E27C0054 for ; Thu, 28 Apr 2022 21:10:33 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 28 Apr 2022 21:10:33 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekgdeflecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefujghffffkgggtsehttdertd dttddtnecuhfhrohhmpeflrghmvghsucfprdcuggdrucevrghshhcuoehjrghmvghsrdhn vhgtsehgmhgrihhlrdgtohhmqeenucggtffrrghtthgvrhhnpeduhedtueekkeeivdefke dufeekieeljeegheffhfeiveeuhfekuefffefgieelkeenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjrghmvghspggtrghshhdomhgvshhmth hprghuthhhphgvrhhsohhnrghlihhthidquddvfedvtddvjeelvddqvdejkeegtdduhedv qdhjrghmvghsrdhnvhgtpeepghhmrghilhdrtghomhesohgttggrshhiohhnrghllhihtg hoghgvnhhtrdgtohhm X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 28 Apr 2022 21:10:33 -0400 (EDT) In-Reply-To: <87k0b84tfr.fsf@occasionallycogent.com> Received-SPF: pass client-ip=209.85.222.179; envelope-from=james.nvc@gmail.com; helo=mail-qk1-f179.google.com X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288954 Archived-At: "James N. V. Cash" writes: > With the changes to pass affixes to the completion functions, the > begin and end points passed to the completion function are now > sometimes strings instead of numbers or markers. This handles that > case by searching for said prefix and suffix. > > Without this, completion functions that call `completion--replace` error > out -- for example, completing tags in org-mode. Hm, while my patch does fix the error I was seeing, it makes completing multiple items with completing-read-multiple not properly insert subsequent completions. I also note that I only saw the aberrant behaviour while using functions that used CRM, so perhaps there's a more underlying cause and/or better place to fix this. James