From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New packages: Vcomplete, swsw Date: Sun, 22 May 2022 11:48:42 +0000 Message-ID: <87h75hyehx.fsf@posteo.net> References: <875ylx4yvn.fsf@dsemy.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26262"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Daniel Semyonov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 22 13:49:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nsk5i-0006e5-FN for ged-emacs-devel@m.gmane-mx.org; Sun, 22 May 2022 13:49:46 +0200 Original-Received: from localhost ([::1]:48750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nsk5h-0002LN-31 for ged-emacs-devel@m.gmane-mx.org; Sun, 22 May 2022 07:49:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsk4q-0001Yp-F4 for emacs-devel@gnu.org; Sun, 22 May 2022 07:48:53 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:35009) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsk4l-0005Vk-IP for emacs-devel@gnu.org; Sun, 22 May 2022 07:48:52 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id EF4AE240027 for ; Sun, 22 May 2022 13:48:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1653220124; bh=TYke6aJeRD3dyzr1b6+lD6MB7exx0DK/0wr1sTtqm9Q=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=YB9/eX8erl5vmt3PgKJTxoYBKo9L1BSWj6qYVyMmterqj83DbeEUNXce+P3yyN5iQ TzQ9/EFLvEm2vpDCe9pj2VmmSuBdJnlQ3Y6IWEYu0Re7yIJ16IRHH2EBprpfSuS9rw ZTNFNoTOFMhrENMGOCxuugFcq+wrhUZ1OqVvO8BbxpReXm87iCrFy+e0pbVwlX7Xgo J5u0XkSQ2gMXToVYMj/xirEbdao32yCRIJrjURGhvYYELyN0PFlNUbPur9prftRffe 98nj7UB3nNTOWksKHwiotVY90ua+L0pekCgSOaGIO66VUwT3pOTVwE3TKFdQdhzMO3 ZckxTV61dipZA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4L5dyg3RPyz9rxN; Sun, 22 May 2022 13:48:43 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <875ylx4yvn.fsf@dsemy.com> (Daniel Semyonov's message of "Sun, 22 May 2022 13:58:52 +0300") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290089 Archived-At: Daniel Semyonov writes: > Hi, > > I'd like to submit two packages to NonGNU ELPA: Vcomplete and swsw. > > Vcomplete provides a minor mode enhancing the default completion list > buffer. > It is designed to change as little as possible so as to remain > compatible with other enhancements to the default completion interface, > while also providing entry points for advanced users who wish to perform > actions on completion candidates. > > From the package commentary: > > When `vcomplete-mode' is active: > - The completion list buffer opens and updates automatically (see > `vcomplete-auto-update'). > - The completion list buffer can be controlled through the > minibuffer (during minibuffer completion) or the current buffer > (during in-buffer completion), if it's visible. > - The currently selected completion is highlighted in the > completion list buffer. > > C-n moves point to the next completion. > > C-p moves point to the previous completion. > > M-RET (C-M-m) chooses the completion at point. > > Source code: https://sr.ht/~dsemy/vcomplete > Homepage (change log and manual): https://dsemy.com/projects/vcomplete Very interesting. From a brief look at the repo, I just have a few questions/comments: - You add vcomplete-embark.el, that seems to be a package in it's own right (with a dependency on embark), but with your patch this will just be bundled into the same package. Is this intentional? - A practice I have taken up for my own packages on SourceHut is to add the mailing list as the maintainer. I'm not saying you should do the same, just that it might make sense to mention it somewhere. - The -pkg.el file should be unnecessary, as ELPA generates its own. - Could the vector key syntax ([?\C-a]) be replaced with a (kbd "C-a")? I think the general trend nowadays is towards the latter, and more people are familiar with it. - You should probably format the reference to the manual in your commentary section as described in the Info node (elisp) Documentation Tips. I hope to try it out soon and give comments on the code + behaviour too. > swsw (simple window switching) provides a minor mode for switching to > windows using IDs assigned to them automatically. > It is designed to be easily extensible, providing ways to change how IDs > are displayed and to easily define new actions to be performed on > windows. Have you made up your mind about the name, or could you be convinced to change it to something like "window-switch" or "windswitch" (so that it sounds similar to windmove)? Just suggestions of course, I just anticipate a discussion on this question, because the name itself is not that expressive. > From the package commentary: > > When swsw-mode is active: > - A window ID is displayed using a mode line lighter or a display > function (see `swsw-display-function'). > - Window IDs are assigned to all windows on all frames except for > the minibuffer(by default, see `swsw-scope'). > - `other-window' (C-x o by default) is remapped to `swsw-select'. > > C-x o ID switches focus to the window which corresponds to ID. > > C-x o m switches focus to the minibuffer if it's active. > > C-x o 0 ID deletes the window which corresponds to ID. > > Source code: https://sr.ht/~dsemy/swsw > Homepage (change log and manual): https://dsemy.com/projects/swsw The same comments as above, for the most part. > Both packages include Texinfo manuals (from which the manuals on their > homepages is generated). > Please let me know beforehand if there is intention to add either > package to NonGNU ELPA, so I could update their manuals and add > '.elpaignore' files to their repositories. I don't see why not. > Attached are patches for nongnu.git adding these packages. > > Regards, > Daniel > > PS: I initially intended to submit these packages to GNU ELPA, but > unfortunately I probably won't be able to assign copyright any time > soon. (I'm assuming it would be possible to move them to GNU ELPA in the > future?) It should be possible.