From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Taiju HIGASHI Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add an option to not reduce vocabulary of the Japanese Date: Sun, 05 Jun 2022 01:39:00 +0900 Message-ID: <87h750e63f.fsf@taiju.info> References: <87r146o2rt.fsf@taiju.info> <8335gme0ml.fsf@gnu.org> <87a6auz1p4.fsf@taiju.info> <83pmjqc89p.fsf@gnu.org> <87sfolwyzj.fsf@taiju.info> <83ee04bz70.fsf@gnu.org> <87h750tzwh.fsf@taiju.info> <83bkv8bl2p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20959"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) Cc: handa@gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 04 18:41:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nxWqH-0005Hh-6Q for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Jun 2022 18:41:37 +0200 Original-Received: from localhost ([::1]:45710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nxWqF-0000lX-OU for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Jun 2022 12:41:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37542) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxWnu-0008JW-RN for emacs-devel@gnu.org; Sat, 04 Jun 2022 12:39:10 -0400 Original-Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:34680) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nxWnq-0004k4-JS for emacs-devel@gnu.org; Sat, 04 Jun 2022 12:39:10 -0400 Original-Received: by mail-pl1-x630.google.com with SMTP id n8so9018287plh.1 for ; Sat, 04 Jun 2022 09:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=taiju-info.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iWi47NdOnuWc0lLcDhDdj4oFQxvYaUT1ooBF5S0Y6S8=; b=lygYT93FCo1QkIdUJL6GpM4FK7tIWuQDWvxWT7hQfG+4Qv9Ve87O3xDI4NQSBhHz8h D1GVDmFDPi8fJt5hYO+0tE/Vfto6wiXt28ImI88CYBFgtLj3RymPrFmNQszERElZSXCt xkJHjjuAT9Ro4QLfpmK9O/nYP7nx9oTStFEwOmcpcAj4YWHXSaGIPX4D+yHuzDVONWrX nscbDRTFOSW+AKp5VneoULOEb4wGZ/c/ccxHtcSMtbjKS/G7+3KQhqzjTgSvG1Bsdyxn St+DnVUKmMIHoEuYB4TNRyziE1PKhAm9lyIfh1Zw8IlawnAec+msQEThFIqoGFLZrkwl 7YZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=iWi47NdOnuWc0lLcDhDdj4oFQxvYaUT1ooBF5S0Y6S8=; b=HAWipuBFm4mkuFTr9E+y8a9kS4gViLX2R4R958dq11IBIPkbimXsI7j58wEwDDFKjp B4JF2+4r0RyRtwfEZYTvkADhFACxwPVZZdysuMfnqPwMxTVZAiWRcpstfjzHRMhVRjKF vnxE0lvWG9E0YARTuHB0EcZOQ5cEt/yyWQ9aRa0X0URrygDcvnZG1q3++Dg/8lE+Ez3f rP4Kew4DIWV/HYZzJkrODRTMpkszPNEzKAcK2SAiloQkoi/RAyAyuWSSzfu+jTK8GCg4 k8feLflink3lE3YhX9liPxSlrxDwkCdvJxq2SEOz27SHl61HLcEiR0FoSZq9qNdSN/PZ iD6Q== X-Gm-Message-State: AOAM533bk9syevLm7TBrZmK6cN67DekgLBQ5PiCGieoaXi3PWPPyYwbh nQLOedGOVUn8clZZ4Aq69bsA+nIJg29bcZwL X-Google-Smtp-Source: ABdhPJzrDaM6XmFcfG9Qw1J1cDIuRiF8AWaEJ+fO/0c7jHZKnjqojt+zt/p9icNAr9yugcxID75TFA== X-Received: by 2002:a17:90a:7381:b0:1e2:ff0f:df07 with SMTP id j1-20020a17090a738100b001e2ff0fdf07mr17046953pjg.160.1654360744528; Sat, 04 Jun 2022 09:39:04 -0700 (PDT) Original-Received: from Taix ([240b:253:ec40:2400:b7d1:436e:2d61:e925]) by smtp.gmail.com with ESMTPSA id e186-20020a6369c3000000b003fd4bd3befesm2088844pgc.55.2022.06.04.09.39.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jun 2022 09:39:04 -0700 (PDT) In-Reply-To: <83bkv8bl2p.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 04 Jun 2022 16:43:42 +0300") Received-SPF: none client-ip=2607:f8b0:4864:20::630; envelope-from=higashi@taiju.info; helo=mail-pl1-x630.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290664 Archived-At: >> > I thought no changes were needed, because one could already say >> > something like >> > >> > make ja-dic.el JA_DIC_REDUCTION='' >> > >> > Wouldn't that work? Perhaps in lisp/Makefile.in one should make sure >> > the JA_DIC_REDUCTION value was propagated to the sub-make running in >> > leim/, but that's all. >> > >> > Am I missing something? >> > >> > Thanks. >> >> I may not have understood it properly. >> >> Did you imagine that the special rules for re-generating would be >> implemented in lisp/Makefile? > > The rules for re-generating with and without reduction should be in > one place, in the same Makefile. > >> In that case, are you saying that there is no need to modify the >> leim/Makefile? >> Certainly, if that is the case, you may be right. >> >> For example, what about the idea of adding regenerate-ja-dic and >> regenerate-ja-dic-without-reductoin as new special rules in >> lisp/Makefile? > > I'm saying that the same rule could serve both kinds of re-generation, > because the only difference is the single option passed to the Emacs > invocation. We can rely on the user who want to re-generate the > dictionary to supply the option manually, when invoking Make. > > So no separate rules should be necessary. I see. If that is the case, then the v1 patch may be sufficient. With the current rules, the dictionary file has to be deleted beforehand by a gen-clean rule or something to regenerate it, but should I add a rule to force regeneration even if the dictionary file has already been generated? Sorry for my lack of understanding :’( -- Taiju