From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] new package: tramp-docker Date: Sat, 24 Sep 2022 12:34:37 +0200 Message-ID: <87h70xrrgi.fsf@gmx.de> References: <5674f36a-c276-fd77-b4d2-1525c75a1602@spork.org> <87y1uarnhu.fsf@gmx.de> <63d5f29a-05ed-f8c5-796c-a6eb9e28d575@spork.org> <87tu4yrmwi.fsf@gmx.de> <87mtaqrmio.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17777"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Brian Cully Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 24 12:35:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oc2Vb-0004U5-UM for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Sep 2022 12:35:43 +0200 Original-Received: from localhost ([::1]:42798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oc2Va-00043N-Uf for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Sep 2022 06:35:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc2Uh-00035B-C8 for emacs-devel@gnu.org; Sat, 24 Sep 2022 06:34:47 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:34349) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc2Uc-0001CQ-Fc for emacs-devel@gnu.org; Sat, 24 Sep 2022 06:34:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1664015680; bh=UTnb5XYF2R1nKWRP71aQ/i2GTPGisK+by5kvJUQJCVA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Jzpgi7UuLm9wwbLzLskQ3OCLl1uMNVCKAxeBSCGtjF9pVTtkgpu78T/8SeMO2p0Iy V/wiOl2fQhtsrLJ656gRclKnBcffFmq/LisBsb+F0gGirq0ZDIRrvaXBXBCEwSwAdx TVx8MYS8k5d78lsMEhCvTW5RZXnb5tz2Vd2KS8Oc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.156.101]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MPGVx-1ouugM3AQ1-00PhT1; Sat, 24 Sep 2022 12:34:39 +0200 In-Reply-To: <87mtaqrmio.fsf@gmx.de> (Michael Albinus's message of "Fri, 23 Sep 2022 20:09:03 +0200") X-Provags-ID: V03:K1:7Fi7mdtBG5+kLQGh7SBTlyzjV1f2bsW1n103hoa6sxW6nRfk5my 908hjnt7yn46FbOOPpOVlvUfLeWzvYjfBntvwuTm0pDK7aKbPW/nsNbhqskpPm/gIvkVpyE +Uwo2zhRl3TMP0YOGDwcgVO+HMo80zIx678BebuhxMqh2ZEQjlIBb+x/msRDR6PRJLKdkIW wzFkKhD4Na8lxl9top60Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:wFvmQA8szSw=:8syDAmgNyQQlirxxPpv+km LJaITLJ0Qh7W7+9FPuZYV+u/lkwBvdsxL2moVOhqqPp1ilBCmkHn/EgqOW88BkqIvIMoLUwLa x4FefgYq1mw7i6YYkEDayK9+fLOBKwA6bFrjnrsdxI8qHcC0Evwicu+Gqfi4AfbzBM7iMdw9t EW118kM99GojZRZSKHdwFIn8MQz8cqM/qQMaci9l5SuaLrnK3b4rxSvohy+F/rbqKHdTNcYKE +jY0iJH3YqHsohj4/xhHGVgyBxUZsyVoDOfFDDgA1D4FVyXcPWEilVT9BrkU5gGOSXMokq83R Q3uIbR9jO8delK1qrbaW7v+roLOZpLc1/G4BTHHIgpZgOtp3AKZHTdw4Y/AWvuUYDVER1goeC 7vEwWLq8a4LAcy5eZYFy77QzbyVMfH4kFXSiQMDsFRrnvz1bp39LSfTRl0O1d1eqN1+mhfOWN emeQuIxCcKPaM5MxKueDs7KlJPBcEBlOovejiuTDWpKyiUD5MK20rbWjSMycoE2hLqBh/4s2V MIygHxivsV+/MzuXSBeHACDxn9kp52iIoMfYZ8Tv982/iTba+pK4NjRVCm91sX5eAMUFWWPRE nzJkP0MbYbtk6JKaZn5YU4RoioAoXtsqi7EIL/KtNXp0GZdOdJmO8zhDDaNsfp8cpphzbJKdW odDHRs/YLC0Y59NMBLnUvpRU+cHsyeG99260Fms/8tUox7Tk/YwrMAk5dT3LbKi91pHzfGzuv MCR6+HsdJT9zy6mfgDE9bAKVba6nnXiZ1kmRkneQL0bzejXdVY/K0SsEytAkY797xjnf8Jn2 Received-SPF: pass client-ip=212.227.17.20; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296140 Archived-At: Michael Albinus writes: Hi Brian, >> Let me read the code over the weekend. Likely, we can simply add your >> (slighly modified) file to the Tramp repo. After that, we can think >> about enhancements, like Tramp manual update, implementing host name >> completion, etc. This stuff. > > I've just seen there's already completion functionality. Hmm, let me > read (test) the code, before I make further suggestions. It works almost in the Tramp environment. So I propose I add it (in your name) to the Tramp and Emacs git repositories, master branch. After that I'll apply some changes for better integration, like removing tramp-docker-setup and friends, which aren't needed anymore. There are some minor problems with tramp-docker--completion-function, because I'm running Fedora 36 and using the "docker" command, which emits an additional message when /etc/containers/nodocker doesn't exist. But these things we can fix afterwards. You have a comment ";; todo: check tramp-async-args and tramp-direct-async" which I didn't follow yet, but this can be investigated also afterwards. Also multi-hops I didn't check yet. Do you agree? With this approach, tramp-docker.el would be part of Tramp 2.6 and Emacs 29. Later, when Tramp 2.6 is distributed via GNU ELPA, it will be available also for older Emacsen down to Emacs 26. Roughly, I expect this for the end of this year (but pls don't beat me when there are delays). Best regards, Michael.