unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: F. Jason Park <jp@neverwas.me>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "João Távora" <joaotavora@gmail.com>, emacs-devel@gnu.org
Subject: Re: emacs-29 8bf4cdcf79: Avoid recursive process filters in lisp/jsonrpc.el (bug#60088)
Date: Fri, 16 Dec 2022 21:37:36 -0800	[thread overview]
Message-ID: <87h6xufv4v.fsf@neverwas.me> (raw)
In-Reply-To: <jwvv8mb2ze9.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 16 Dec 2022 09:36:02 -0500")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>     Avoid recursive process filters in lisp/jsonrpc.el (bug#60088)
>
> BTW, this has bitten us in various other cases, we should fix it once
> and for all in the C code by marking the process as "busy" while we're
> running the filters so we never run filters recursively.
> [ If we ever bump into a case where recursive filters are needed, we
>   can then add some function to remove the "busy" mark.
>   Calling (accept-process-output PROC) should naturally mark PROC as
>   not-busy.  ]
>
>
>         Stefan

A possibly related discussion from the bug archive:

  https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-03/msg01211.html



  parent reply	other threads:[~2022-12-17  5:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <167118072395.30479.8819833637573037468@vcs2.savannah.gnu.org>
     [not found] ` <20221216085204.43B07C04961@vcs2.savannah.gnu.org>
2022-12-16 14:36   ` emacs-29 8bf4cdcf79: Avoid recursive process filters in lisp/jsonrpc.el (bug#60088) Stefan Monnier
2022-12-16 14:46     ` João Távora
2022-12-16 14:56       ` Stefan Monnier
2022-12-17  5:37     ` F. Jason Park [this message]
2022-12-17 15:37       ` Stefan Monnier
2022-12-17 21:39         ` João Távora
2022-12-18  1:57           ` Stefan Monnier
2022-12-18  4:08             ` João Távora
2022-12-18 14:32               ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6xufv4v.fsf@neverwas.me \
    --to=jp@neverwas.me \
    --cc=emacs-devel@gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).