From: Po Lu <luangruo@yahoo.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: feature/android b91e8ada70e 3/5: Fix auto-revert-mode on Android
Date: Sat, 25 Feb 2023 19:13:41 +0800 [thread overview]
Message-ID: <87h6va2e1m.fsf@yahoo.com> (raw)
In-Reply-To: <87fsauvx2v.fsf@gmx.de> (Michael Albinus's message of "Sat, 25 Feb 2023 11:49:44 +0100")
Michael Albinus <michael.albinus@gmx.de> writes:
> Po Lu <luangruo@yahoo.com> writes:
>
> Hi,
>
>>> I have two problems with this patch. First, nil is not defined as return
>>> value of *-add-watch functions. If we want to allow this, we must extend
>>> the interface.
>>>
>>> Second, do we really want to have such a hard coded list in inotify.c?
>>> What about other directories on other systems, like "/proc"? Shouldn't
>>> we add rather a common interface for excluding directories from being
>>> watched, say file-notify-excluded-directories (a list of strings)? This
>>> could be modified on Lisp level, no need to do it in the notification
>>> backends.
>>
>> Shouldn't watching /proc work, in that no error is signalled, unlike
>> watching /content and /assets, which are wholly inventions of android.c
>> which do not exist in the VFS?
>
> I haven't checked /proc, it was just the first example which came to
> mind for a directory we might want to exclude. Other examples might be
> mounted directories, which could also fail for watching files.
>
>> Anyway, what return value do you think would be appropriate here?
>
> nil might be a correct return value. We haven't simply specified it, and
> implementing a file-notify-excluded-directories would give the backends
> a simple way to achive the goal, w/o modifying C source.
Hmmm... I'd rather go with modifying C, since the whole point of using
/content and /assets is to be as transparent as possible towards Lisp.
IOW, Lisp shouldn't care. It should get the same results for /assets
that any other directory gets, except that no file notifications can be
generated, as /assets cannot change.
Thanks.
next prev parent reply other threads:[~2023-02-25 11:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167724502313.15669.16640007729364817665@vcs2.savannah.gnu.org>
[not found] ` <20230224132344.40927C1391F@vcs2.savannah.gnu.org>
2023-02-25 10:27 ` feature/android b91e8ada70e 3/5: Fix auto-revert-mode on Android Michael Albinus
2023-02-25 10:41 ` Po Lu
2023-02-25 10:49 ` Michael Albinus
2023-02-25 11:13 ` Po Lu [this message]
2023-02-25 11:51 ` Michael Albinus
2023-02-25 12:19 ` Po Lu
2023-02-25 12:28 ` Michael Albinus
2023-02-26 0:49 ` chad
2023-02-26 2:40 ` Po Lu
2023-02-27 3:03 ` chad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6va2e1m.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).