From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: eglot-test-diagnostic-tags-unnecessary-code fails with certain clangd versions Date: Tue, 21 Mar 2023 14:49:29 +0100 Message-ID: <87h6uep63a.fsf@gmail.com> References: <87edq7ztks.fsf.ref@yahoo.com> <875yb3vftq.fsf@gmail.com> <87zg8f7h2d.fsf@yahoo.com> <871qlrvcc7.fsf@gmail.com> <87wn3jtwxg.fsf@gmail.com> <87v8j37ehz.fsf@yahoo.com> <87sfe7tr57.fsf@gmail.com> <87y1nzv18a.fsf@gmail.com> <87ilf27tt1.fsf@yahoo.com> <87jzziuzba.fsf@gmail.com> <87pm9a5n14.fsf@yahoo.com> <87bkkuulp5.fsf@gmail.com> <87wn3h4gld.fsf@yahoo.com> <87o7oru7i1.fsf@gmail.com> <87ttyj3i3u.fsf@yahoo.com> <87a6071xxt.fsf@yahoo.com> <87bkknr7io.fsf@gmail.com> <87355zqzbh.fsf@gmail.com> <87pm92pmtn.fsf@gmail.com> <87lejqp7zc.fsf_-_@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7174"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , emacs-devel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 21 14:50:07 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pecNK-0001iw-SA for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Mar 2023 14:50:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pecMs-0007xw-Ng; Tue, 21 Mar 2023 09:49:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pecMr-0007xo-Pj for emacs-devel@gnu.org; Tue, 21 Mar 2023 09:49:37 -0400 Original-Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pecMq-0002p0-9m for emacs-devel@gnu.org; Tue, 21 Mar 2023 09:49:37 -0400 Original-Received: by mail-wr1-x434.google.com with SMTP id e18so2209580wra.9 for ; Tue, 21 Mar 2023 06:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679406571; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=M2fA38czng1RDRsqfW5mkLDBenFoytbZUcW5Hw4QIL0=; b=phZDq7H0UBzHAJKgE+LNJBhcE5xV4eWeCT+h7Heh0R/ZQFq3xSaJps2WV+pz2tkNu1 AyDQ7t8XgU+vzPBfU6nsAkH/TS38HEJw/7IGMXAGNIzak1jJ8+DWdAoKld+oxtWlx2WW lULzxWvsAjoLMA/z0OOOjwzU5vdPpNVT8I66fgQvdawSruUN0lQouuVwVdoXFyl6f+mJ 5qUaRVmCz5YB2Te8YHoQlU8J1SylajCxb24yH5OQ0zTiCIMOe0dnLWFs03h8GqBHp2vo XHs2eKNQNj3X1MrMdrjmUg/TSBHHo19DAIZ8fqAh/TjgaRbaAXvleQBrvmUndYkgoHuj EP5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679406571; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M2fA38czng1RDRsqfW5mkLDBenFoytbZUcW5Hw4QIL0=; b=fMrmUQSuF87jKoxn2kFYnPbTnG267quV5Vg1yfucIxxETpc1bh21G6gmBbcaVZgLSn qpVwwNrckJXCJ7gy+4N5JnbdxI4k7lepmeFqEMTYyZi6K1waario4tpATZAiMIdRqNay mAKKrtfGl6wJEmmtKW0k9mLx3i/xlu+MdtTVqb8lsp9Igm1mE5gVMbz3eiOTTpoB55et jq0B4ZXGVwwxEeAuJUbxU9NFrxDVICz3Z5xgQsNDDGLTqjdWOEx6hbmsjKC1zNsWn1L7 JtJn6QpBP+viqQcNQ5RNV6FxIhTKHRWUDBW5SpBtxTAS4vKJvASgfhhBhmvIYJvFvqnR 6Wcw== X-Gm-Message-State: AO0yUKXipDBrlf6Z8dRFyNlQTM7S/j8HwYFlXGZoGWvlRvO7bLe2V/zx dIUG0+snID1Xofka+lM2Ai780kVpLA4= X-Google-Smtp-Source: AK7set+fRLjsbiUuEhE/0LiHAkdDfoiYmgIBDOQzRAvJ+eW3z2chuvcg2JjlSVguHqAypy1AVjifpg== X-Received: by 2002:a5d:5492:0:b0:2ce:aed4:7f22 with SMTP id h18-20020a5d5492000000b002ceaed47f22mr2430400wrv.50.1679406571012; Tue, 21 Mar 2023 06:49:31 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id w2-20020a5d6802000000b002cfe687fc7asm11325932wru.67.2023.03.21.06.49.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 06:49:30 -0700 (PDT) In-Reply-To: <87lejqp7zc.fsf_-_@gmail.com> (Robert Pluim's message of "Tue, 21 Mar 2023 14:08:39 +0100") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=rpluim@gmail.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304652 Archived-At: >>>>> On Tue, 21 Mar 2023 14:08:39 +0100, Robert Pluim s= aid: >>>>> On Tue, 21 Mar 2023 08:48:04 +0100, Robert Pluim s= aid: >>>>> On Mon, 20 Mar 2023 17:34:22 +0000, Jo=C3=A3o T=C3=A1vora said: Jo=C3=A3o> _If_ I understand correctly, Robert, your run of Jo=C3=A3o> eglot-test-diagnostic-tags-unnecessary-code is failing Jo=C3=A3o> because of a face mismatch, presumably because only Jo=C3=A3o> clangd-11 is installed in your system, but if you install Jo=C3=A3o> a more recent clangd it goes away? If so, yes, I think a Jo=C3=A3o> version check is appropriate, yes. Robert> Yes. Version 11 fails, version 17 works, I don=CA=BCt know wher= e the cutoff Robert> point is. Which version do you use? Robert> So version 11 fails, version 13 fails, version 14 works, so I g= uess >=3D Robert> 14 should do the trick. Jo=C3=A3o, would this be ok for you for master? (this test is currently failing on EMBA =F0=9F=98=80) diff --git a/test/lisp/progmodes/eglot-tests.el b/test/lisp/progmodes/eglot= -tests.el index 7ac26732737..dfe969cf9f6 100644 --- a/test/lisp/progmodes/eglot-tests.el +++ b/test/lisp/progmodes/eglot-tests.el @@ -452,6 +452,14 @@ eglot-test-basic-diagnostics (ert-deftest eglot-test-diagnostic-tags-unnecessary-code () "Test rendering of diagnostics tagged \"unnecessary\"." (skip-unless (executable-find "clangd")) + (skip-unless (>=3D + (string-to-number + (string-trim + (replace-regexp-in-string + "\\`.*version \\([0-9]+\\).*" + "\\1" + (shell-command-to-string "clangd --version")))) + 14)) (eglot--with-fixture `(("diag-project" . (("main.cpp" . "int main(){float a =3D 42.2; return 0;}")))) Robert --=20