From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sam Steingold Newsgroups: gmane.emacs.devel Subject: Re: Org mode update breaking build? Date: Tue, 09 May 2023 13:17:28 -0400 Message-ID: <87h6sl4e6v.fsf@gnu.org> References: <00b52cc1-b0ac-a0c0-c91d-33a7213e9881@web.de> <83v8h9l5cw.fsf@gnu.org> <87lehx4g6i.fsf@gnu.org> <83v8h1a1uv.fsf@gnu.org> Reply-To: sds@gnu.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17524"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org, Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 09 19:18:17 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwQyc-0004JZ-KM for ged-emacs-devel@m.gmane-mx.org; Tue, 09 May 2023 19:18:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwQy3-0003Qf-U5; Tue, 09 May 2023 13:17:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwQy0-0003QA-28 for emacs-devel@gnu.org; Tue, 09 May 2023 13:17:36 -0400 Original-Received: from mail-qv1-xf36.google.com ([2607:f8b0:4864:20::f36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwQxv-0000R3-Th; Tue, 09 May 2023 13:17:34 -0400 Original-Received: by mail-qv1-xf36.google.com with SMTP id 6a1803df08f44-61b79b9f45bso57774046d6.3; Tue, 09 May 2023 10:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683652649; x=1686244649; h=content-transfer-encoding:mime-version:message-id:date :mail-followup-to:reply-to:return-receipt-to:user-agent:references :in-reply-to:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=/RtG9uxVizLlMqp4hAjahJz0NGfOUx3vn5Bqwk2Yv8U=; b=RTAQb9b6prsIx6mg4i6vr0tTitAYAhCmVM7l7PRAJodrkzZBz+IaJQHqA8b/PxRN3m DtRUUiXNEFMgaZCKVth3z85pnb++/lakaw7p9RJR6QVOE4DEG0OoW8ZrKZOzwe+n6HpG 60QgqIS8IO5vBfIm/P00VMOXv2JiFUdt0wwjpkxniLuNW9fzhsRiQ9LRoWa7YGHuCh2D QqokQuTCBHlzsldcPj5g6xvwiGUjnvT9eEEyknHjiqFlSN/kHKnnISeicmcTf37oI8v7 /sx3h1QoJSt8sxddKrs7Z8sXgLPz0qL/a2SYNJ4YuREsY14chugetfbcPJ0Ahn7MbhBx vspg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683652649; x=1686244649; h=content-transfer-encoding:mime-version:message-id:date :mail-followup-to:reply-to:return-receipt-to:user-agent:references :in-reply-to:subject:to:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/RtG9uxVizLlMqp4hAjahJz0NGfOUx3vn5Bqwk2Yv8U=; b=XI0MZ23ORjDv7WItHilkKRU5/usJEgJzu7RKktuqmByHwZXEeQqvty6dxJbQ2bKDQv D6bQk8i1t3WeZYSDzb/pmj/k7dZ1gx0H1DKF7c0wULATY6uC3yAYUcpygCVR6uWk9wjt 8s9SpkpGqIrwx9un6geGMrPODOjMT3tQxauCsvQBupfuDRi7lzQtHR76fPNYgjL47Y3g LZGKsWWL0rIo1NVrWefn210PxbzRlNSPZlMUmDyOTLeIpIZKp0v0l4pzj3brxBXJl0WF qIWlEINILrdLHaTirugCr2QQMGcRHCRmkrjlpmx2gv3wSi+FMwXRvx+Y13+SHgq3e/Ag NzXg== X-Gm-Message-State: AC+VfDxfLlpN9aZt2Q3CmF682RyNCvZqZq8WEAjQvdRLl3GJ0mygtLBN gByQ+BV94gnn9Uz1VlaJb5DeDVjoQA== X-Google-Smtp-Source: ACHHUZ53eqgO40L/fmqQLytz1/Smt8lW3Otiro6hAev1dkcERW7aop+8MmB+q/+06X5F1k/GXpJ7qA== X-Received: by 2002:ad4:5b84:0:b0:5ea:922:bea9 with SMTP id 4-20020ad45b84000000b005ea0922bea9mr20508533qvp.14.1683652649334; Tue, 09 May 2023 10:17:29 -0700 (PDT) Original-Received: from darter (pool-162-83-143-31.nycmny.fios.verizon.net. [162.83.143.31]) by smtp.gmail.com with ESMTPSA id e15-20020a0caa4f000000b00606322241b4sm911289qvb.27.2023.05.09.10.17.28 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 May 2023 10:17:28 -0700 (PDT) In-Reply-To: <83v8h1a1uv.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 May 2023 19:47:20 +0300") X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. Mail-Followup-To: emacs-devel@gnu.org, Eli Zaretskii Received-SPF: pass client-ip=2607:f8b0:4864:20::f36; envelope-from=sam.steingold@gmail.com; helo=mail-qv1-xf36.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306012 Archived-At: > * Eli Zaretskii [2023-05-09 19:47:20 +0300]: > >> From: Sam Steingold >> Date: Tue, 09 May 2023 12:34:29 -0400 >>=20 >> > * Eli Zaretskii [2023-05-03 19:58:07 +0300]: >> > >> > We already fixed that, but only on master. So you don't need to >> > convince anyone that this needed fixing. We are convinced. >>=20 >> I built from git master and did not get any errors. >> However, when I visited an org-mode file, I got this: >>=20 >> --8<---------------cut here---------------start------------->8--- >> Debugger entered--Lisp error: (error "Org version mismatch. Make sure t= hat correct =E2=80=98load-path=E2=80=99 is set early in init.el") >> --8<---------------cut here---------------end--------------->8--- >>=20 > > That's expected when there's an incompatible change. It can also > happen with other packages, not just with Org. It's nothing new. sad. >> Basically, an apparently successful build no longer guarantees that >> the resulting Emacs will be working. > > That was never guaranteed. Not just when Org changed. I have never seen this before, sorry. >> It would seem that if the build process can detect this "Org version >> mismatch", it should just `rm -f lisp/org/*.elc` and restart (remembering >> that it tried this hack to avoid an infinite loop if it does not work). > > Feel free to propose how to detect this, and then restart, without > disrupting the whole build. We are not just compiling Org, we compile > hundreds of Lisp files, so whatever you propose should be consistent > with how the normal build proceeds, including its support for high > parallelism. If a better solution will be found, we will surely > embrace it. I can describe how CLISP handles this: (https://clisp.sourceforge.io/impnotes/require.html#lib-files and https://lists.gnu.org/archive/html/emacs-devel/2021-10/msg00274.html) Compilation of `foo.el` should produce 2 files: 1. `foo.elc`, as now - this is the code whose loading is functionally equivalent to loading `foo.el`. 2. `foo.elh` ("header") - this contains only the compile-time dependencies (i.e., compiled `defvar`, `defconst`, `defmacro`, and `defsubst` definitions and function declarations), When the compiler sees `(require 'foo)`, it will check whether `foo.elh` has changed since last loaded and will reload it automatically. Note that `foo.elh` is (probably) much smaller than `foo.elc` and thus cheaper to load. For "pre-built" files like `subr.el` (which no other file ever requires): when `subr.el` is recompiled, we check whether `subr.elh` has changed, and, if it did, everything needs to be recompiled. If it did not, no action is necessary. Thank you for your kind an informative reply. --=20 Sam Steingold (https://aphar.dreamwidth.org/) on Pop 22.04 (jammy) X 11.0.1= 2101004 https://lastingimpactpsychology.com https://steingoldpsychology.com https://iris.org.il https://memri.org https://mideasttruth.com To iterate is human; to recurse, divine.