unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tony Zorman <tonyzorman@mailbox.org>
To: emacs-devel@gnu.org, Protesilaos Stavrou <info@protesilaos.com>
Subject: Ansi-color uses the same values for fore- and background colours
Date: Wed, 09 Aug 2023 14:10:44 +0200	[thread overview]
Message-ID: <87h6p8mn5n.fsf@hyperspace> (raw)

Hi,

by default, all of the `ansi-color-«COLOUR»' faces (defined in
`ansi-color.el') set the foreground and background colour to the exact
same value. Depending on the colour scheme, this can lead to text that's
quite hard to read. The question is whether this is intentional, because
some component or other relies on it, or it's just that no one bothered
to think of good matches here.

This was originally a bug report for the modus-themes.[1] Here is the
relevant part of the email:

---

[…] this can result in hard to read text; for example:

    https://i.imgur.com/nZsh00N.png

Notice the blue background in the bottom left corner. Here's a
reproducer:

  1. Basic environment: $ emacs -Q --eval "(load-theme 'modus-operandi)"

  2. Start `term': M-x term RET

     In a second prompt, `term' asks you to choose a shell. To make sure
     no user options are at play here, I opted for `/bin/sh' (this is
     dash for me).

  3. Do something that involves a pager: git add --help

  4. Notice that the temp file name in the bottom left has a very dark
     blue background, making the text almost—or, depending on the
     monitor, completely—illegible.

     Upon pressing any key, the title will vanish. However, one can also
     search for something, which uses the same face: / This RET

---

Note that I'm not necessarily advocating for changing the defaults,
although that would be the most desirable outcome. This is just to make
sure that the modus-themes using different fore- and background colours
doesn't violate any implicit assumptions.

  Tony

[1]: https://lists.sr.ht/~protesilaos/modus-themes/%3C87fs4wforf.fsf%40hyperspace%3E

-- 
Tony Zorman | https://tony-zorman.com/



             reply	other threads:[~2023-08-09 12:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09 12:10 Tony Zorman [this message]
2023-08-09 13:28 ` Ansi-color uses the same values for fore- and background colours Eli Zaretskii
2023-08-09 16:18   ` Tony Zorman
2023-08-09 16:31     ` Eli Zaretskii
2023-08-09 16:46   ` Jim Porter
2023-08-09 16:51 ` Jim Porter
2023-08-10  3:59   ` Tony Zorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6p8mn5n.fsf@hyperspace \
    --to=tonyzorman@mailbox.org \
    --cc=emacs-devel@gnu.org \
    --cc=info@protesilaos.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).