From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make ispell localwords safe local variable Date: Tue, 15 Aug 2023 18:41:18 -0700 Message-ID: <87h6ozdalc.fsf@breatheoutbreathe.in> References: <87zg2s97x0.fsf@breatheoutbreathe.in> <83o7j8a59k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34330"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 16 04:22:02 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qW6Ab-0008gH-7E for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Aug 2023 04:22:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qW69Z-0007IN-1F; Tue, 15 Aug 2023 22:20:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qW5aw-0006ig-Tj for emacs-devel@gnu.org; Tue, 15 Aug 2023 21:45:11 -0400 Original-Received: from out-17.mta0.migadu.com ([2001:41d0:1004:224b::11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qW5au-0001Ms-0z for emacs-devel@gnu.org; Tue, 15 Aug 2023 21:45:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1692150305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/rSEQyEu92JvH3RgYuIatWSMUpNv+63uIHQLoz8ULjM=; b=GhB6YgsP6MUJMvGBCppmycRBz9sGjxXm8z+HhqkBq0lgSnIY36s5V+RPETqZJPUyyJVR6q 4L08/BLB/R9suXKdi/Q70BAW5WNHiHCdthmuSOrNh4gnlfLS1T303y3nl5AvV0+pel+3wj gJWZLiqkzcyw/o9E9qEASFm3g3WqUVo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <83o7j8a59k.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::11; envelope-from=joseph@breatheoutbreathe.in; helo=out-17.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 15 Aug 2023 22:20:53 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308785 Archived-At: Eli Zaretskii writes: >> From: Joseph Turner >> Date: Mon, 14 Aug 2023 22:40:24 -0700 >> >> In this PR , we made it >> possible for checkdoc/ispell to ignore localwords stored in a >> .dir-locals.el when run in batch mode. >> >> It seemed appropriate to upstream this fix. > > I'm not sure this is indeed safe enough. We send these words to the > spell-checker; are we sure this couldn't be abused by malicious people > to perform some destructive actions? I am not sure. Unless someone can be certain that ispell can safely handle arbitrary strings, I think it's prudent to discard this patch. Joseph