From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: &allow-other-keys + &rest body in cl-defmacro (was: Permanently fix org versioning breakage during builds?) Date: Mon, 25 Dec 2023 12:21:31 +0000 Message-ID: <87h6k6o4l0.fsf@localhost> References: <25989.50971.995591.385250@google.com> <87a5q0dc9m.fsf@localhost> <87edfbbyzm.fsf@localhost> <875y0n4px0.fsf@localhost> <87r0jb34hi.fsf@localhost> <878r5j31v0.fsf@localhost> <87a5pya5ga.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1990"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "T.V Raman" , emacs-devel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 25 13:19:13 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rHjvM-0000Hg-Fr for ged-emacs-devel@m.gmane-mx.org; Mon, 25 Dec 2023 13:19:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rHjud-0003eS-Gh; Mon, 25 Dec 2023 07:18:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHjub-0003e2-LL for emacs-devel@gnu.org; Mon, 25 Dec 2023 07:18:25 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHjuZ-0006Kc-AP for emacs-devel@gnu.org; Mon, 25 Dec 2023 07:18:25 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 35AF6240104 for ; Mon, 25 Dec 2023 13:18:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1703506700; bh=+NU+TXZQVPfIeZz3qyB26nrlQpwoqxS4QObZ8m6/K9Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=PH86GlysJiMQ7OUADn1xxQpHdLFnFaG8nWTX/X8Djd1GxcbunFbhrrkwsIEZF4uFD qz0Mfk5PtR4DHqQNcr7cP8u2tnMuu+v02FE8UPBWG7PmaqXXV5ts7rergMtYdVt7cW AIdSU7kUl22O9QNlRrxewksmHRttOPxf5RLVIbFbpYIRoBaFVViZ4WvNksYNisY0c5 MZI1XKLVjAnEGq0W834iEOdP6OywKsC70p7QBElY9UE9xeWjKFN4Yug0vXqGTpu/TV FvvS89VizMN9TLkeYWjwStBEui+3P2gU7V/jDmXVw8uQ+ScQQCUen6tMw8YLO9uqNV XUKgyrW+lsfPQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SzH4C1V2Lz6tvd; Mon, 25 Dec 2023 13:18:19 +0100 (CET) In-Reply-To: Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314203 Archived-At: Jo=C3=A3o T=C3=A1vora writes: >> Now I feel a bit like RMS when he complained about CL-lib introducing >> alien concepts to Elisp :) > > It's not Cl-lib's fault that the Org developers made a mistake and didn't > understand how the Common Lisp tool they selected works. I do not blame cl-lib. Mostly grumbling on unexpected concept that is hard to grasp even after reading the manual (maybe, the manual could be improved). > Even in Elisp a zillion macros are correctly written in this form: > > (defmacro with-foo (options-when-fooing &rest body) > > It's exactly the same, only you need to do the destructuring yourself. > cl-defmacro simplifies this for free with > > (cl-defmacro with-foo ((&key option1 option2) &body body) It would be nice if this approach were described in the manual. Now, there is just description of destructuring, but it is very generic. >> What about non-breaking change like the attached? > > You should be checking for `keywordp` instead, because &allow-other-keys. The only reason I used &allow-other-keys is that I couldn't use &rest without specifying &allow-other-keys. (I did not know about ((&key ...) &rest body) trick when writing this macro= .) --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at