From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: NonGNU ELPA: Conditions for accepting a potential new package 'rmsbolt' ? Date: Tue, 27 Feb 2024 17:27:58 +0000 Message-ID: <87h6htu89t.fsf@posteo.net> References: <87jzmsmecw.fsf@jeremybryant.net> <877cir8yap.fsf@posteo.net> <877ciqn8wg.fsf@jeremybryant.net> <87y1b6tkk1.fsf@posteo.net> <87msrleuwd.fsf@eve> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3979"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jay Kamat , Jeremy Bryant , "emacs-devel@gnu.org" To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 27 18:28:54 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rf1G9-0000jB-Kt for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Feb 2024 18:28:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rf1FP-00022p-Ei; Tue, 27 Feb 2024 12:28:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rf1FO-00022T-7h for emacs-devel@gnu.org; Tue, 27 Feb 2024 12:28:06 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rf1FM-0002K4-1i for emacs-devel@gnu.org; Tue, 27 Feb 2024 12:28:05 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id C0A91240029 for ; Tue, 27 Feb 2024 18:27:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1709054879; bh=8UK/f4GBlQqJfNUVfQEW/BiLQqCv5ci711skmmsQkaI=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=Kt0EervPuXmYLfrrBshHruC2QM+5zs7oC74ezroPPZsus51Qn1Y3C9lu9JnvE/1wK Bdl3Wbed6puxZA2fVp0TA7LCTnRg9A1uUvaDcLzEvR8Dd5oibCdkSiogQ1k0Q2BTi8 gnIUJFMKcyNogL3/3MoNouc2Ifm7Q55+j2Zw1OnGKov6qSeRVe81TJ5tJ4uvnLoeb1 HEGAIKEBhGZheuW3Kjpj9v+JwKIT5/b5m/eeiqFcP1tekrkJtTFU2sZP2GsyXiFL9X srMMydYEs2Wrw4La7yBVOHnUQkqxLho/CY2RyybFuosDpImT/AVTFgvIhdsrQf2i+3 hrM1TudetFIOw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Tkkvy6H3pz6txS; Tue, 27 Feb 2024 18:27:58 +0100 (CET) In-Reply-To: (Stefan Monnier's message of "Tue, 27 Feb 2024 12:21:24 -0500") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316596 Archived-At: Stefan Monnier writes: >>> -(defun rmsbolt--convert-file-name-to-system-type (file-name) >>> +(defun rmsbolt--convert-file-name-to-system-type (file-name) ;perhaps use >>> `convert-standard-filename'? >> >> Right now, a contributor is trying to improve this area/enable tramp >> support - so I'd like to keep this as stable as possible while they do >> so. But this is a great suggestion - I'll let them know about this function >> and hopefully it will help them in their change as well! > > I haven't looked at the code but I'll point out that > `convert-standard-filename` is meant to *define* the name of a "standard" > file, so its argument is usually very static. > It doesn't make sense to apply it to something like `buffer-file-name` > which is already supposed to be a valid filename. In that case I must have misunderstood something, my intention was to find a function that would convert file names with forwards slashes to the proper file delimiters on the current system. > Also, I see: > > (rmsbolt--convert-file-name-to-system-type > (shell-quote-argument > > which is very weird. The reverse would make more sense. > > Also I think `shell-quote-argument` should be applied to most parts of > `rmsbolt--demangle-command`. This function is also odd in that it > calls `rmsbolt--convert-file-name-to-system-type` on the files > of the demangler but not those of the `mv`. IIUC shell-quote-argument cannot be used, since rmsbolt is actually creating a shell command out of a list, where each element of the list is not necessarily a command line argument. E.g. there were some places where "&&" or ">" were being used, and quoting those would break the intended functionality. I have to admit that the process of creating commands this way seems fragile, but there is a lot of code that would take a while to rewrite and verify that it doesn't break anything. (A different idea would be to have a defstruct for each command that would be prepared into a list and in the end executed in order, ideally using some function like `process-file'). -- Philip Kaludercic on peregrine