Re: [ELPA] New consult-denote package

[Philip Kaludercic <philipk@posteo.net>]

[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]

Protesilaos Stavrou <info@protesilaos.com> writes:

> Hello folks!
>
> I plan to push the attached change to elpa.git. Any thoughts?
>
> The goal of this package is to enhance the minibuffer prompts of
> 'denote' with some of the features provided by 'consult'.
>
> Both Consult and Denote are on GNU ELPA.
>
> All the best,
> Protesilaos (or simply "Prot")
>
> -- 
> Protesilaos Stavrou
> https://protesilaos.com
>
> From c3097070c9a427764c05749daecc6c303b87ec72 Mon Sep 17 00:00:00 2001
> Message-Id: <c3097070c9a427764c05749daecc6c303b87ec72.1715167446.git.info@protesilaos.com>
> From: Protesilaos Stavrou <info@protesilaos.com>
> Date: Wed, 8 May 2024 14:23:15 +0300
> Subject: [PATCH] * elpa-packages (consult-denote): Add new package
>
> ---
>  elpa-packages | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/elpa-packages b/elpa-packages
> index de66d29..02babee 100644
> --- a/elpa-packages
> +++ b/elpa-packages
> @@ -170,6 +170,8 @@
>    :doc "README.org"
>    :news "CHANGELOG.org"
>    :ignored-files ("LICENSE"))
> + (consult-denote		:url "https://github.com/protesilaos/consult-denote"
> +  :readme "README.md")
>   (consult-hoogle	:url "https://codeberg.org/rahguzar/consult-hoogle"
>    :ignored-files ("LICENSE"))
>   (consult-recoll	:url "https://codeberg.org/jao/consult-recoll"

Here are a few quick comments:


[-- Attachment #2: Type: text/plain, Size: 2481 bytes --]

diff --git a/consult-denote.el b/consult-denote.el
index 135838e..76895a8 100644
--- a/consult-denote.el
+++ b/consult-denote.el
@@ -90,7 +90,7 @@ aforementioned function."
     (let* ((default-directory (denote-directory))
            (common-parent-directory
             (let ((common-prefix (try-completion "" all-files)))
-              (if (> (length common-prefix) 0)
+              (if (length> common-prefix 0)
                   (file-name-directory common-prefix))))
            (cpd-length (length common-parent-directory))
            (prompt-prefix (or prompt-text "Select FILE"))
@@ -101,16 +101,16 @@ aforementioned function."
                            (setq all-files
                                  (delete common-parent-directory all-files))
                            t))
-           (substrings (mapcar (lambda (s) (substring s cpd-length)) all-files))
-           (_ (when included-cpd
-                (setq substrings (cons "./" substrings))))
+           (substrings (append
+			(if included-cpd '("./"))
+			(mapcar (lambda (s) (substring s cpd-length)) all-files)))
            (new-collection (denote--completion-table 'file substrings))
            ;; We populate the history ourselves because we process the input.
            (input
             (consult--read new-collection
                            :state (consult--file-preview)
                            :prompt prompt))
-           ;; FIXME 2024-05-08: Is there some elegant way to do this?
+           ;; FIXME 2024-05-08: Is there some elegant way to do this? what is "this"
            (filename (with-temp-buffer
                        (insert input)
                        (completion-in-region (point-min) (point-max) new-collection)
@@ -164,14 +164,13 @@ aforementioned function."
 
 (defun consult-denote--buffers ()
   "Return file names of Denote buffers."
-  (delq nil
-        (mapcar
-         (lambda (buffer)
-           (when-let ((file (buffer-file-name buffer))
-                      ((buffer-live-p buffer))
-                      ((denote-filename-is-note-p file)))
-             (buffer-name buffer)))
-         (buffer-list))))
+  (mapcan				;or use `match-buffers'
+   (lambda (buffer)
+     (and-let* ((file (buffer-file-name buffer))
+                ((buffer-live-p buffer))
+                ((denote-filename-is-note-p file)))
+       (list (buffer-name buffer))))
+   (buffer-list)))
 
 (defvar consult-denote--buffer-source
   `( :name "Denote buffers"

[-- Attachment #3: Type: text/plain, Size: 38 bytes --]



-- 
	Philip Kaludercic on peregrine