unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Morgan Willcock <morgan@ice9.digital>,  emacs-devel@gnu.org
Subject: Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback)
Date: Sat, 21 Sep 2024 09:28:40 +0200	[thread overview]
Message-ID: <87h6a979ef.fsf@gnu.org> (raw)
In-Reply-To: <86setu5f85.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Sep 2024 21:53:30 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> When testing the Emacs 30 pre-release I found that all of the PDF
>> files which I tried to view were not readable because the text
>> appeared to be missing.
>> 
>> Eventually I found the variable doc-view-mupdf-use-svg, and setting
>> it to nil reverted the rendering to the old method where the text was
>> visible.
>
> Why is that?  If your system supports display of SVG images, why
> wasn't the text readable?  Tassilo, any ideas?

I suspect it's some sort of background-equals-foreground issue.  I think
by default, the SVGs have transparent background.  So when you use a
dark theme (I tested with the built-in modus-vivendi theme which is very
dark), you might get black foreground on black background.

Visuwesh already cited the cure: in emacs 29 you might want to set
doc-view-svg-foreground/background to white/black or vice versa (and
then re-convert your PDF).

In emacs 30, that has been replaced with the face doc-view-svg-face
where you can customize foreground and background such that the contrast
works for you and your theme.

Hm, but doc-view-svg-face inherits from the default face and that is
white-on-black with modus-vivendi, so actually it should all be good,
i.e., the PDF display should match your theme.  However, depending on
PDF I tested, I sometimes get white-on-black display (good!) and
sometimes darkish-on-black (bad!).  It seems like it works as intended
for "standard black-on-white PDFs" but doesn't really work when the PDF
is "fancy", e.g., gray foreground or colorized borders or what not...

Bye,
  Tassilo



  parent reply	other threads:[~2024-09-21  7:28 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-20 17:53 No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback) Morgan Willcock
2024-09-20 18:53 ` Eli Zaretskii
2024-09-20 19:34   ` Visuwesh
2024-09-20 19:39   ` Morgan Willcock
2024-09-20 22:29     ` chad
2024-09-20 22:46       ` Morgan Willcock
2024-09-21  8:09     ` Eli Zaretskii
2024-09-21  9:27       ` Morgan Willcock
2024-09-21 17:35         ` Tassilo Horn
2024-09-22 20:57           ` Morgan Willcock
2024-09-23  6:44             ` Tassilo Horn
2024-09-23  8:34               ` Manuel Giraud via Emacs development discussions.
2024-09-23  8:45                 ` Tassilo Horn
2024-09-23 11:34                   ` Manuel Giraud via Emacs development discussions.
2024-09-23 11:56                 ` Eli Zaretskii
2024-09-23 14:51                   ` Tassilo Horn
2024-09-23 15:35                     ` Eli Zaretskii
2024-09-23 15:50                       ` Morgan Willcock
2024-09-23 16:10                       ` Tassilo Horn
2024-09-23 16:27                         ` Eli Zaretskii
2024-09-23 16:54                           ` Tassilo Horn
2024-09-24 11:17                             ` Eli Zaretskii
2024-09-24 11:22                               ` Tassilo Horn
2024-09-23 17:56                         ` Manuel Giraud via Emacs development discussions.
2024-09-23 18:35                           ` Tassilo Horn
2024-09-23 19:06                             ` Manuel Giraud via Emacs development discussions.
2024-09-23  9:36               ` Visuwesh
2024-09-23 11:55               ` Eli Zaretskii
2024-09-23 12:05                 ` Tassilo Horn
2024-09-23 15:32                   ` Eli Zaretskii
2024-09-21  7:28   ` Tassilo Horn [this message]
2024-09-21  9:27     ` Morgan Willcock
2024-09-21 11:04       ` Visuwesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6a979ef.fsf@gnu.org \
    --to=tsdh@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=morgan@ice9.digital \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).