From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: [RFC] The best way to choose an "action" at point: context-menu-mode, transient, which-key or embark? (was: Fwd: Org-cite: Replace basic follow-processor with transient menu?) Date: Sat, 14 Dec 2024 09:48:20 +0000 Message-ID: <87h676fvdn.fsf@localhost> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26518"; mail-complaints-to="usenet@ciao.gmane.io" Cc: charles.choi@yummymelon.com, Emacs developers , emacs-orgmode@gnu.org, emacs.transient@jonas.bernoulli.dev, juri@linkov.net, justin@burkett.cc, karthikchikmagalur@gmail.com, omar@matem.unam.mx, Philip Kaludercic , tclaesson@gmail.com, visuweshm@gmail.com To: Psionic K Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 14 10:47:50 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tMOkY-0006kx-0B for ged-emacs-devel@m.gmane-mx.org; Sat, 14 Dec 2024 10:47:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMOjp-0002mj-Ra; Sat, 14 Dec 2024 04:47:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMOjo-0002mT-Ue for emacs-devel@gnu.org; Sat, 14 Dec 2024 04:47:04 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMOjm-0003jS-GJ for emacs-devel@gnu.org; Sat, 14 Dec 2024 04:47:04 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id CCEEA240101 for ; Sat, 14 Dec 2024 10:46:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1734169618; bh=VEqMTiLX3aFCg4wsgyLqZpwcMPn0fp/ak61tLQ18HpM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=rnkY3zDbl3jUI/TqGBLKQkb4cRJ+DfAPZ8T1ilccTYP9I8bHBtkXvEt/DObZ105f2 GwyCkUZi7P3z5Y2WPUjQdvmkjiOsVsqqQXs0gXGVnFl52tzeWipT14yVmRQXa6P171 mzLpzDxNeC10NjlCVq/+FVCR5/L7gm6UuHgnIGAJNfOw2HDkUSS42M6s/ev0OMnyQF NtwcvAfG7AF0BOomOwWw9f8IZ/6x+TDstDmJmZ6v6ahj5gNFnmsC04ZJeY/WlXWlzD eWGQGSYrT1dLPUdWmBMXxKPW4X8ONW63NC+uee2LInv0ANC9Q3A0r3hmQlCDhnQ2Ac JsuVXgZVzAD0Q== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Y9Lvg3YPdz9rxF; Sat, 14 Dec 2024 10:46:55 +0100 (CET) In-Reply-To: Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326469 gmane.emacs.orgmode:164133 Archived-At: Psionic K writes: >> intercepts the main loop > This is optional, per transient menu (prefix) and the commands within it. > A common technique, used by magit and others, is to have entry point > commands in the regular keymap so that many commands can be started without > traversing several menus. If you want normal un-shadowed bindings active > at the same time, the prefix has a slot called `transient-non-suffix' that > is similar to the `:suppress' option in keymaps or setting a `t' > `undefined' binding in a keymap. However the results of mixing self-insert > and modal or modal and another modal are generally bad. Thanks for the info! So, we can have something like :transient-non-suffix 'leave and then pressing something that is not bound to a suffix or infix will run the parent keymap command, automatically leaving transient state. > - Normalizing how to obtain arguments when being called independently as an > interactive command versus being called as a Transient suffix I think it is addressed in the example patch I shared. There, we pass around the original function arguments via macro expansion (!arg-name) ["Open" ("b" "bibliography entry" (org-cite-basic-goto !citation !prefix))] > In the short term, to punch the first two problems in the face, override > the `:setup-children' method. If you know what keymap you are borrowing > bindings from, you can synchronize it at display time. This is also partially solved. We do use :setup-children, although the initial implementation simply reads user customization into menu layout. I believe that we can read a keymap in similar way and generate transient layout automatically. > What I fear is a system like org-speed-keys which relies on an override of > `org-self-insert' and is yet another orthogonal system. I much prefer the > Lispy style of integration, which uses a keymap. Using keymaps, even if > they are not active, to generate transient key bindings via :setup-children > is the best way to have certain integration with other Emacs tools. May you please elaborate? -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at . Support Org development at , or support my work at