unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Psionic K <psionik@positron.solutions>
Cc: charles.choi@yummymelon.com,
	Emacs developers <emacs-devel@gnu.org>,
	emacs-orgmode@gnu.org, emacs.transient@jonas.bernoulli.dev,
	juri@linkov.net, justin@burkett.cc, karthikchikmagalur@gmail.com,
	omar@matem.unam.mx, Philip Kaludercic <philipk@posteo.net>,
	tclaesson@gmail.com, visuweshm@gmail.com
Subject: Re: [RFC] The best way to choose an "action" at point: context-menu-mode, transient, which-key or embark? (was: Fwd: Org-cite: Replace basic follow-processor with transient menu?)
Date: Sat, 14 Dec 2024 09:48:20 +0000	[thread overview]
Message-ID: <87h676fvdn.fsf@localhost> (raw)
In-Reply-To: <CADQMGARM+5J9t_apzOL+kZ2c1kz+ooA-0+aFSwjGqAFoudoKHA@mail.gmail.com>

Psionic K <psionik@positron.solutions> writes:

>> intercepts the main loop

> This is optional, per transient menu (prefix) and the commands within it.
> A common technique, used by magit and others, is to have entry point
> commands in the regular keymap so that many commands can be started without
> traversing several menus.  If you want normal un-shadowed bindings active
> at the same time, the prefix has a slot called `transient-non-suffix' that
> is similar to the `:suppress' option in keymaps or setting a `t'
> `undefined' binding in a keymap.  However the results of mixing self-insert
> and modal or modal and another modal are generally bad.

Thanks for the info!
So, we can have something like

:transient-non-suffix 'leave

and then pressing something that is not bound to a suffix or infix will
run the parent keymap command, automatically leaving transient state.

> - Normalizing how to obtain arguments when being called independently as an
> interactive command versus being called as a Transient suffix

I think it is addressed in the example patch I shared. There, we pass
around the original function arguments via macro expansion (!arg-name)

  ["Open" ("b" "bibliography entry" (org-cite-basic-goto !citation !prefix))]

> In the short term, to punch the first two problems in the face, override
> the `:setup-children' method.  If you know what keymap you are borrowing
> bindings from, you can synchronize it at display time.

This is also partially solved. We do use :setup-children, although the
initial implementation simply reads user customization into menu layout.

I believe that we can read a keymap in similar way and generate
transient layout automatically.

> What I fear is a system like org-speed-keys which relies on an override of
> `org-self-insert' and is yet another orthogonal system.  I much prefer the
> Lispy style of integration, which uses a keymap.  Using keymaps, even if
> they are not active, to generate transient key bindings via :setup-children
> is the best way to have certain integration with other Emacs tools.

May you please elaborate?

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



  reply	other threads:[~2024-12-14  9:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-14  0:37 [RFC] The best way to choose an "action" at point: context-menu-mode, transient, which-key or embark? (was: Fwd: Org-cite: Replace basic follow-processor with transient menu?) Psionic K
2024-12-14  9:48 ` Ihor Radchenko [this message]
2024-12-14 10:12   ` [RFC] The best way to choose an "action" at point: context-menu-mode, transient, which-key or embark? Philip Kaludercic
     [not found] <8734m28l9a.fsf@gmail.com>
     [not found] ` <87wmhlmp83.fsf@gmail.com>
     [not found]   ` <871pzte929.fsf@localhost>
     [not found]     ` <87v7x548ri.fsf@gmail.com>
     [not found]       ` <87y120daue.fsf@localhost>
     [not found]         ` <874j4m9ep6.fsf@gmail.com>
     [not found]           ` <87h68gfqj1.fsf@localhost>
     [not found]             ` <CAO0k701CGFnQwCCuODjTFuf=OTsj9Vdqg+COP8nkpJg0wL_hQg@mail.gmail.com>
     [not found]               ` <87pln3f3cc.fsf@localhost>
     [not found]                 ` <CAO0k7006goK-AfhG+3PVwhz=4QU_DMm+5edmATZpjdRHkj61Bg@mail.gmail.com>
     [not found]                   ` <87jzd9ojj0.fsf@localhost>
     [not found]                     ` <87cyj0ajm9.fsf@gmail.com>
     [not found]                       ` <87zfm4s50x.fsf@localhost>
     [not found]                         ` <CAO0k703a5SCv4Eaogjs-14zgmTi-pK5qqG=8VzB8+7h-kcC8yg@mail.gmail.com>
     [not found]                           ` <87wmh8s358.fsf@localhost>
     [not found]                             ` <87y11nwp9z.fsf@gmail.com>
     [not found]                               ` <CAO0k702GsRi-h8BEY08kpf5FzMxi_MvRygNXJCyFnbtaC-a59w@mail.gmail.com>
     [not found]                                 ` <87v7wd9a2h.fsf@localhost>
     [not found]                                   ` <878qt7fbki.fsf@gmail.com>
     [not found]                                     ` <87o71jwdxz.fsf@localhost>
     [not found]                                       ` <87wmg6edr0.fsf@gmail.com>
2024-12-13 18:41                                         ` [RFC] The best way to choose an "action" at point: context-menu-mode, transient, which-key or embark? (was: Fwd: Org-cite: Replace basic follow-processor with transient menu?) Ihor Radchenko
2024-12-14  1:16                                           ` Panayotis Manganaris
2024-12-14 10:08                                             ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h676fvdn.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=charles.choi@yummymelon.com \
    --cc=emacs-devel@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=emacs.transient@jonas.bernoulli.dev \
    --cc=juri@linkov.net \
    --cc=justin@burkett.cc \
    --cc=karthikchikmagalur@gmail.com \
    --cc=omar@matem.unam.mx \
    --cc=philipk@posteo.net \
    --cc=psionik@positron.solutions \
    --cc=tclaesson@gmail.com \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).