From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-trunk-diffs] Changes to emacs/lisp/faces.el Date: Tue, 28 Dec 2004 04:38:14 +0200 Organization: JURTA Message-ID: <87fz1r9j5x.fsf@jurta.org> References: <87mzwsws3d.fsf@jurta.org> <41B6317B.6020303@esperanto.org> <41BC0D29.9020007@t-online.de> <87sm5wfhh3.fsf@jurta.org> <87ekhcsurb.fsf@jurta.org> <01c4ebea$Blat.v2.2.2$4d937300@zahav.net.il> <87r7lbikl4.fsf@jurta.org> <01c4ec5f$Blat.v2.2.2$d17a06a0@zahav.net.il> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1104206935 25529 80.91.229.6 (28 Dec 2004 04:08:55 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 28 Dec 2004 04:08:55 +0000 (UTC) Cc: bob@rattlesnake.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 28 05:08:49 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Cj8fB-0000nP-00 for ; Tue, 28 Dec 2004 05:08:49 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Cj8q0-0000LL-G3 for ged-emacs-devel@m.gmane.org; Mon, 27 Dec 2004 23:20:00 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Cj8ps-0000Ky-6z for emacs-devel@gnu.org; Mon, 27 Dec 2004 23:19:52 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Cj8pq-0000K5-Mj for emacs-devel@gnu.org; Mon, 27 Dec 2004 23:19:51 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Cj8pq-0000JW-8P for emacs-devel@gnu.org; Mon, 27 Dec 2004 23:19:50 -0500 Original-Received: from [194.126.101.98] (helo=MXR-5.estpak.ee) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Cj8am-0003MR-8u; Mon, 27 Dec 2004 23:04:16 -0500 Original-Received: from mail.neti.ee (80-235-41-238-dsl.mus.estpak.ee [80.235.41.238]) by MXR-5.estpak.ee (Postfix) with ESMTP id BFD0311CADA; Tue, 28 Dec 2004 06:03:58 +0200 (EET) Original-To: Eli Zaretskii In-Reply-To: <01c4ec5f$Blat.v2.2.2$d17a06a0@zahav.net.il> (Eli Zaretskii's message of "Tue, 28 Dec 2004 00:01:51 +0200") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-2.2.1 (20041222) (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:31503 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:31503 "Eli Zaretskii" writes: > No, the minibuffer-prompt face is one of the few cases where the > literal `pc' is deliberate. It so happens that many users of the > MS-DOS port use blue as their default foreground color. Aha. But then a condition like ((class color) (background "blue")) would be mode appropriate. Not for this release, though. >> The idea was to make escape-glyph to look like comments > > I'm not sure that was a good idea, since comments normally have a face > that makes them stand out. I thought that several people complained > about ^L being too glaring. For light background color "dark red" does not stand out. The color for dark background for (min-colors 88) perhaps does not stand out too (if bright colors which don't stand out are possible at all). But there is no color for 8-color terminals which does not stand out. Thus, there is red for (min-colors 8). Another choice would be not to highlight escape sequences 8-color terminals. >> +(defface escape-glyph >> + '((((class color) (min-colors 88) (background light)) >> + :foreground "dark red") >> + (((class color) (min-colors 88) (background dark)) >> + :foreground "tan1") >> + (((class color) (min-colors 8)) >> + :foreground "red")) >> + "Face for characters displayed as ^-sequences or \\-sequences." >> :group 'basic-faces) -- Juri Linkov http://www.jurta.org/emacs/