From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Diff mode faces Date: Sat, 09 Jul 2005 23:56:19 +0300 Organization: JURTA Message-ID: <87fyunwph1.fsf@jurta.org> References: <87oea5urwm.fsf@jurta.org> <87psujj0h0.fsf@jurta.org> <86hdfv1y9b.fsf@blue.stonehenge.com> <87r7eyqzcy.fsf@jurta.org> <200506191710.j5JHAEN11479@raven.dms.auburn.edu> <877jgfi40l.fsf@jurta.org> <874qb7k65j.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1120956915 3517 80.91.229.2 (10 Jul 2005 00:55:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 10 Jul 2005 00:55:15 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 10 02:55:15 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DrQ62-0006lS-6s for ged-emacs-devel@m.gmane.org; Sun, 10 Jul 2005 02:55:02 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DrQ7W-0005l8-Jv for ged-emacs-devel@m.gmane.org; Sat, 09 Jul 2005 20:56:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DrQ7I-0005jJ-Hy for emacs-devel@gnu.org; Sat, 09 Jul 2005 20:56:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DrQ4r-00059w-Qo for emacs-devel@gnu.org; Sat, 09 Jul 2005 20:54:02 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DrQ4n-00053F-OJ for emacs-devel@gnu.org; Sat, 09 Jul 2005 20:53:45 -0400 Original-Received: from [194.126.101.111] (helo=mail.neti.ee) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DrPud-0005GR-3a; Sat, 09 Jul 2005 20:43:15 -0400 Original-Received: from mail.neti.ee (80-235-34-69-dsl.mus.estpak.ee [80.235.34.69]) by Relayhost1.neti.ee (Postfix) with ESMTP id 091A11E95; Sun, 10 Jul 2005 03:36:02 +0300 (EEST) Original-To: Eli Zaretskii In-Reply-To: (Eli Zaretskii's message of "Thu, 07 Jul 2005 06:42:39 +0200") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-2.2.1 (20041222) (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:40702 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:40702 >> Are there any objections to changing context fg/bg to the default fg/bg >> and file header's yellow foreground to green on light background tty? > > Please post the suggested diffs, I'd like to try that before I make up > my mind about this proposal. Index: lisp/diff-mode.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/diff-mode.el,v retrieving revision 1.78 diff -u -r1.78 diff-mode.el --- lisp/diff-mode.el 4 Jul 2005 23:08:52 -0000 1.78 +++ lisp/diff-mode.el 9 Jul 2005 20:09:20 -0000 @@ -197,7 +197,7 @@ (((class color) (min-colors 88) (background dark)) :background "grey60" :weight bold) (((class color) (background light)) - :foreground "yellow" :weight bold) + :foreground "green" :weight bold) (((class color) (background dark)) :foreground "cyan" :weight bold) (t :weight bold)) ; :height 1.3 @@ -259,7 +280,8 @@ (defvar diff-function-face 'diff-function) (defface diff-context - '((t :inherit shadow)) + '((((type tty pc) (class color))) + (t :inherit shadow)) "`diff-mode' face used to highlight context and other side-information." :group 'diff-mode) ;; backward-compatibility alias -- Juri Linkov http://www.jurta.org/emacs/