From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.cc-mode.general,gmane.emacs.devel Subject: Re: [sigra@home.se: C++-mode: Syntax highlighting: wrong color for function identifier depending on the kind of whitespace that follows] Date: Wed, 15 Feb 2006 19:38:53 -0500 Message-ID: <87fymkdua9.fsf-monnier+emacs@gnu.org> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1140050414 20789 80.91.229.2 (16 Feb 2006 00:40:14 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 16 Feb 2006 00:40:14 +0000 (UTC) Cc: Ralf Angeli , bug-cc-mode@gnu.org, rms@gnu.org, emacs-devel@gnu.org Original-X-From: cc-mode-help-admin@lists.sourceforge.net Thu Feb 16 01:40:08 2006 Return-path: Envelope-to: sf-cc-mode-help@m.gmane.org Original-Received: from lists-outbound.sourceforge.net ([66.35.250.225]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F9XBk-0007aN-3h for sf-cc-mode-help@m.gmane.org; Thu, 16 Feb 2006 01:40:04 +0100 Original-Received: from sc8-sf-list1-b.sourceforge.net (sc8-sf-list1-b.sourceforge.net [10.3.1.7]) by sc8-sf-spam2.sourceforge.net (Postfix) with ESMTP id 5A9A9127BE; Wed, 15 Feb 2006 16:40:03 -0800 (PST) Original-Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1F9XB3-0000q1-7d for cc-mode-help@lists.sourceforge.net; Wed, 15 Feb 2006 16:39:21 -0800 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by mail.sourceforge.net with esmtps (TLSv1:RC4-SHA:128) (Exim 4.44) id 1F9XB1-0003AZ-Oc for cc-mode-help@lists.sourceforge.net; Wed, 15 Feb 2006 16:39:21 -0800 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.34) id 1F9XAn-0004Gu-5t for bug-cc-mode@gnu.org; Wed, 15 Feb 2006 19:39:08 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.52) id 1F9XFl-0004tJ-0I for bug-cc-mode@gnu.org; Wed, 15 Feb 2006 19:44:16 -0500 Original-Received: from [209.226.175.184] (helo=tomts22-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1F9XFk-0004tD-N5; Wed, 15 Feb 2006 19:44:12 -0500 Original-Received: from alfajor ([67.71.116.200]) by tomts22-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20060216003900.VURQ10262.tomts22-srv.bellnexxia.net@alfajor>; Wed, 15 Feb 2006 19:39:00 -0500 Original-Received: by alfajor (Postfix, from userid 1000) id 74647D7341; Wed, 15 Feb 2006 19:38:53 -0500 (EST) Original-To: Alan Mackenzie In-Reply-To: (Alan Mackenzie's message of "Wed, 15 Feb 2006 19:07:31 +0000 (GMT)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-Spam-Score: 0.0 (/) X-Spam-Report: Spam Filtering performed by sourceforge.net. See http://spamassassin.org/tag/ for more details. Report problems to http://sf.net/tracker/?func=add&group_id=1&atid=200001 Original-Sender: cc-mode-help-admin@lists.sourceforge.net Errors-To: cc-mode-help-admin@lists.sourceforge.net X-BeenThere: cc-mode-help@lists.sourceforge.net X-Mailman-Version: 2.0.9-sf.net Precedence: bulk List-Unsubscribe: , List-Id: Bug reports, feature requests, and general talk about CC Mode. List-Post: List-Help: List-Subscribe: , List-Archive: X-Original-Date: Wed, 15 Feb 2006 19:38:53 -0500 Xref: news.gmane.org gmane.emacs.cc-mode.general:3016 gmane.emacs.devel:50589 Archived-At: >>>> This patch to font-lock is exactly the sort of change I was thinking of. >>>> Could someone please install it, then rename >>>> before-font-lock-after-change-function to >>>> font-lock-extend-region-function, and rename >>>> font-lock-run-before-after-change-hook to font-lock-extend-region? >> .... Based on the name, I suppose it's some kind of hook in >> font-lock-after-change-function, in which case I'd be tempted to suggest >> to move it to font-lock-fontify-region instead, to reduce the >> performance impact and make it easier to deal with lazy-lock&jit-lock >> since these tend to use their own after-change-function. > I strongly oppose such a change. With that change: > (i) font-lock-fontify-region would no longer be fontifying the region > specified by its paramters, but a different (possibly larger) one. That's already the case since font-lock-fontify-region will typically not fontify from BEG to END from the beginning of line before BEG to the end of line after END. Then that can be extended yet further because of font-lock-multiline. Nobody has ever complained about this. So why is it a problem? > (ii) the hook function (which recalculates BEG and END) might well refer > to variables set by a before-change-functions hook. (This is done in AWK > mode, for example). Which variables would that be? > f-l-f-region is regularly called when there is no buffer change in progress. Indeed. Again, why is it a problem? > Both of these things would make debugging a hook function much more > difficult than it already is. Determining the region to fontify and > actually fontifying it are two logically distinct operations. With jit-lock, the region to fontify is not determined by the after-change-functions either. Stefan ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642