From: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org, rms@gnu.org, "Kim F. Storm" <storm@cua.dk>
Subject: Re: jit-lock timer etc.
Date: Mon, 21 Aug 2006 14:51:12 -0400 [thread overview]
Message-ID: <87fyfpq5wf.fsf@stupidchicken.com> (raw)
In-Reply-To: <44E9E5F5.8000400@gmx.at> (martin rudalics's message of "Mon, 21 Aug 2006 18:57:25 +0200")
martin rudalics <rudalics@gmx.at> writes:
>> Martin, would you like to try to update your patch ?
>
> Apparently, my patch works also without restricting the values of
> `run-at-time' as I did earlier. Could you please try the attached
> revision with "pathological" values for `jit-lock-stealth-time' and
> `jit-lock-stealth-nice'.
The patch looks very good to me. I have just one serious question
plus a few nitpicks:
Each time Emacs becomes idle, `jit-lock-stealth-fontify' is called;
with this patch, it requeues itself as a non-idle timer until it
finishes fontifying. What happens if Emacs becomes idle again before
fontification finishes? (This may happen if jit-lock-stealth-time is
very short, or if a timer or process filter makes Emacs idle.) It
seems to me that this will set off another series of non-idle timers,
which is not what we want.
I think that if jit-lock-stealth-fontify is called with no argument,
and fontification is proceeding, it should do nothing. One way to do
this is to introduce a new `jit-lock-stealth-fontifying' variable.
(This may not work well if stealth fontification is so slow that the
buffer list changes significantly before fontification finishes, but I
think there's not much we can do about this.)
Now the nitpicks. First, jit-lock-stealth-buffers should be
defvar'ed.
Second, this part is rather hard to read:
(let (....
load-delay)
(when (or (not jit-lock-stealth-load)
(or (<= (car (load-average)) jit-lock-stealth-load)
(not (setq load-delay t))))
...))
I suggest changing it to
(let (...
(load-delay (and jit-lock-stealth-load
(>= (car (load-average)) jit-lock-stealth-load))))
(when (not load-delay)
...))
Finally, is it really necessary to test jit-lock-stealth-time here?
If it's invalid, jit-lock-stealth-fontify wouldn't get called in the
first place.
(when (and jit-lock-stealth-buffers jit-lock-stealth-time)
(run-at-time
(if load-delay jit-lock-stealth-time (or jit-lock-stealth-nice 0))
nil 'jit-lock-stealth-fontify t))
Other than that, I think this proposal is good.
next prev parent reply other threads:[~2006-08-21 18:51 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-21 11:12 jit-lock timer etc Richard Stallman
2006-08-21 11:39 ` Kim F. Storm
2006-08-21 16:57 ` martin rudalics
2006-08-21 18:51 ` Chong Yidong [this message]
2006-08-21 22:22 ` martin rudalics
2006-08-21 23:26 ` Chong Yidong
2006-08-22 7:18 ` Kim F. Storm
2006-08-22 15:41 ` Richard Stallman
2006-08-23 12:27 ` martin rudalics
2006-08-23 13:09 ` Kim F. Storm
2006-08-24 5:20 ` Richard Stallman
2006-08-24 7:47 ` Kim F. Storm
2006-08-24 7:58 ` Kim F. Storm
2006-08-24 9:07 ` Kim F. Storm
2006-08-24 14:47 ` Chong Yidong
2006-08-25 20:23 ` Richard Stallman
2006-08-25 22:45 ` Kim F. Storm
2006-08-25 20:23 ` Richard Stallman
2006-08-25 21:27 ` Chong Yidong
2006-08-26 12:22 ` Richard Stallman
2006-08-24 9:10 ` Kim F. Storm
2006-08-24 12:23 ` martin rudalics
2006-08-24 12:54 ` Kim F. Storm
2006-08-24 13:07 ` Kim F. Storm
2006-08-24 13:11 ` Kim F. Storm
2006-08-24 13:34 ` Kim F. Storm
2006-08-24 18:11 ` martin rudalics
2006-08-24 20:11 ` Kim F. Storm
2006-08-24 23:41 ` Chong Yidong
2006-08-25 7:17 ` Kim F. Storm
2006-08-24 14:16 ` Chong Yidong
2006-08-24 5:20 ` Richard Stallman
2006-08-24 7:48 ` Kim F. Storm
2006-08-24 12:21 ` martin rudalics
2006-08-24 15:27 ` Chong Yidong
2006-08-24 15:40 ` Chong Yidong
2006-08-24 18:09 ` martin rudalics
2006-08-24 19:16 ` Stefan Monnier
2006-08-24 19:20 ` Stefan Monnier
2006-08-24 16:18 ` martin rudalics
2006-08-24 16:34 ` Chong Yidong
2006-08-24 19:48 ` Chong Yidong
2006-08-25 6:00 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fyfpq5wf.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
--cc=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).