unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: Search minibuffer history
Date: Wed, 11 Jul 2007 01:31:34 +0300	[thread overview]
Message-ID: <87fy3v7uwp.fsf@jurta.org> (raw)
In-Reply-To: <E1I8NmA-0000rn-MI@fencepost.gnu.org> (Richard Stallman's message of "Tue\, 10 Jul 2007 18\:01\:42 -0400")

> Your code still needs a lot more comments.
> Every function and every variable should have a comment,
> and long functions should have an explanation of each part.

I surely will add more comments as well as write changes to etc/NEWS and
the Emacs Manual once the implementation reaches its final state.

>     This code prevents `isearch-message' from overwriting the minibuffer text
>     with the isearch prompt.  Without this condition `isearch-message' calls
>     `message' that puts the isearch prompt over the minibuffer content, so the
>     user can't see the search string highlighted in the minibuffer.
>
> I see the point of this, but if the isearch prompt is not displayed
> at all, how can the user understand the search?

The isearch prompt is displayed over the original prompt which is not
essential at the short time of searching in the minibuffer.  The original
prompt gets restored immediately once the search finishes in the minibuffer.

-- 
Juri Linkov
http://www.jurta.org/emacs/

  reply	other threads:[~2007-07-10 22:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-09 20:59 Search minibuffer history Juri Linkov
2007-07-10  5:38 ` Richard Stallman
2007-07-10 13:14   ` Juri Linkov
2007-07-10 22:01     ` Richard Stallman
2007-07-10 22:31       ` Juri Linkov [this message]
2007-07-11 21:04         ` Richard Stallman
2007-07-11 22:55           ` Juri Linkov
2007-07-12 21:23             ` Richard Stallman
2007-07-15 20:04               ` Juri Linkov
2007-07-16 15:05                 ` Stefan Monnier
2007-07-16 20:54                   ` Juri Linkov
2007-07-16 15:49                 ` Richard Stallman
2007-07-21 18:17                   ` Juri Linkov
2007-07-11 21:04         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fy3v7uwp.fsf@jurta.org \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).