[jidanni@jidanni.org: find-library-name perhaps should try .emacs]

[jidanni@jidanni.org: find-library-name perhaps should try .emacs]

[Richard Stallman]

Would someone please DTRT and ack?

------- Start of forwarded message -------
To: bug-gnu-emacs@gnu.org
From: jidanni@jidanni.org
Date: Mon, 21 Jan 2008 11:05:55 +0800
Message-ID: <87abmzzxm4.fsf@jidanni.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: find-library-name perhaps should try .emacs 

  C-h k runs the command describe-key
which showed me
  C-x t runs the command jidanni-tidy-buffer
  which is an interactive compiled Lisp function in `/home/jidanni/.emacs.elc'.
But when I clicked that filename, I got
  find-library-name: Can't find library /home/jidanni/.emacs.el
Why of course. It's in .emacs, not .emacs.el.

(I use (add-hook 'emacs-lisp-mode-hook '(lambda () (add-hook
 'after-save-hook '(lambda () (byte-compile-file buffer-file-name) )
 nil t))) to make it.) emacs-version "22.1.1"
------- End of forwarded message -------

Re: dired cannot access file names with a quote

[Chong Yidong]

> The subject describes what I suspect is the cause of the bug, but I am
> not sure, because I made no real investigation
>
> $ touch /tmp/First-October\ \'07.pdf
> $ emacs -Q
> C-x d /tmp/Firs TAB RET
>  ==> Listing directory failed but `access-file' worked

I think the fix is to quote ' as well in shell-quote-wildcard-pattern.
Could someone on this list double-check?


*** emacs/lisp/files.el.~1.896.2.37.~	2008-01-29 13:34:43.000000000 -0500
--- emacs/lisp/files.el	2008-02-23 17:25:50.000000000 -0500
***************
*** 4774,4780 ****
  
  PATTERN is assumed to represent a file-name wildcard suitable for the
  underlying filesystem.  For Unix and GNU/Linux, the characters from the
! set [ \\t\\n;<>&|()#$] are quoted with a backslash; for DOS/Windows, all
  the parts of the pattern which don't include wildcard characters are
  quoted with double quotes.
  Existing quote characters in PATTERN are left alone, so you can pass
--- 4774,4780 ----
  
  PATTERN is assumed to represent a file-name wildcard suitable for the
  underlying filesystem.  For Unix and GNU/Linux, the characters from the
! set [ \\t\\n;<>&|()#$'] are quoted with a backslash; for DOS/Windows, all
  the parts of the pattern which don't include wildcard characters are
  quoted with double quotes.
  Existing quote characters in PATTERN are left alone, so you can pass
***************
*** 4806,4812 ****
  	  (concat result (substring pattern beg) "\""))))
       (t
        (let ((beg 0))
! 	(while (string-match "[ \t\n;<>&|()#$]" pattern beg)
  	  (setq pattern
  		(concat (substring pattern 0 (match-beginning 0))
  			"\\"
--- 4806,4812 ----
  	  (concat result (substring pattern beg) "\""))))
       (t
        (let ((beg 0))
! 	(while (string-match "[ \t\n;<>&|()#$']" pattern beg)
  	  (setq pattern
  		(concat (substring pattern 0 (match-beginning 0))
  			"\\"

Re: dired cannot access file names with a quote

[Glenn Morris]

Chong Yidong wrote:

> I think the fix is to quote ' as well in shell-quote-wildcard-pattern.
> Could someone on this list double-check?

Won't that break things like 'foo*' that people might want to pass to
shell-quote-wildcard-pattern, as per the comment in the function's
doc-string?

'foo*' and \'foo*\' are not the same to the shell.

Re: dired cannot access file names with a quote

[Chong Yidong]

Glenn Morris <rgm@gnu.org> writes:

> Chong Yidong wrote:
>
>> I think the fix is to quote ' as well in shell-quote-wildcard-pattern.
>> Could someone on this list double-check?
>
> Won't that break things like 'foo*' that people might want to pass to
> shell-quote-wildcard-pattern, as per the comment in the function's
> doc-string?
>
> 'foo*' and \'foo*\' are not the same to the shell.

Don't the quote characters referred to in the docstring refer to
backslash (\)?

The only place that calls shell-quote-wildcard-pattern in the Emacs
source tree is insert-directory, and the logic in insert-directory
indicates that shell-quote-wildcard-pattern is simply intended to
quote special characters that would screw up the call to `ls'.  Is
there any way of passing a ' character in the file argument to
insert-directory, except as a literal part of a filename?

Re: dired cannot access file names with a quote

[Stefan Monnier]

> I think the fix is to quote ' as well in shell-quote-wildcard-pattern.
> Could someone on this list double-check?

I haven't had time to check if that makes sense, but if it makes sense,
then " should probably be added as well.


        Stefan


> *** emacs/lisp/files.el.~1.896.2.37.~	2008-01-29 13:34:43.000000000 -0500
> --- emacs/lisp/files.el	2008-02-23 17:25:50.000000000 -0500
> ***************
> *** 4774,4780 ****
  
>   PATTERN is assumed to represent a file-name wildcard suitable for the
>   underlying filesystem.  For Unix and GNU/Linux, the characters from the
> ! set [ \\t\\n;<>&|()#$] are quoted with a backslash; for DOS/Windows, all
>   the parts of the pattern which don't include wildcard characters are
>   quoted with double quotes.
>   Existing quote characters in PATTERN are left alone, so you can pass
> --- 4774,4780 ----
  
>   PATTERN is assumed to represent a file-name wildcard suitable for the
>   underlying filesystem.  For Unix and GNU/Linux, the characters from the
> ! set [ \\t\\n;<>&|()#$'] are quoted with a backslash; for DOS/Windows, all
>   the parts of the pattern which don't include wildcard characters are
>   quoted with double quotes.
>   Existing quote characters in PATTERN are left alone, so you can pass
> ***************
> *** 4806,4812 ****
>   	  (concat result (substring pattern beg) "\""))))
>        (t
>         (let ((beg 0))
> ! 	(while (string-match "[ \t\n;<>&|()#$]" pattern beg)
>   	  (setq pattern
>   		(concat (substring pattern 0 (match-beginning 0))
>   			"\\"
> --- 4806,4812 ----
>   	  (concat result (substring pattern beg) "\""))))
>        (t
>         (let ((beg 0))
> ! 	(while (string-match "[ \t\n;<>&|()#$']" pattern beg)
>   	  (setq pattern
>   		(concat (substring pattern 0 (match-beginning 0))
>   			"\\"

Re: dired cannot access file names with a quote

[Chong Yidong]

Chong Yidong <cyd@stupidchicken.com> writes:

>> The subject describes what I suspect is the cause of the bug, but I am
>> not sure, because I made no real investigation
>>
>> $ touch /tmp/First-October\ \'07.pdf
>> $ emacs -Q
>> C-x d /tmp/Firs TAB RET
>>  ==> Listing directory failed but `access-file' worked
>
> I think the fix is to quote ' as well in shell-quote-wildcard-pattern.
> Could someone on this list double-check?

I've checked this change into both the branch and the trunk.  I think
it's safe, but please keep an eye out for anything unusual.