From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: Base patch for bug #5975 (bookmarking from Gnus Article buffer). Date: Wed, 14 Jul 2010 12:57:00 +0200 Organization: ThierryVolpiatto Message-ID: <87fwzmbabn.fsf@tux.homenetwork> References: <87y6dydn6q.fsf@tux.homenetwork> <201006292126.15409.tassilo@member.fsf.org> <87iq51ehnv.fsf@tux.homenetwork> <201006292210.43121.tassilo@member.fsf.org> <87eifpegqx.fsf@tux.homenetwork> <87k4ozdq6b.fsf_-_@red-bean.com> <87d3urdppj.fsf@red-bean.com> <87sk3mbh60.fsf@tux.homenetwork> <83oceaqx0z.fsf@gnu.org> <87oceabfga.fsf@tux.homenetwork> <83mxtuqtzz.fsf@gnu.org> <87k4oybcll.fsf@tux.homenetwork> <83lj9eqsdh.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1279105224 32446 80.91.229.12 (14 Jul 2010 11:00:24 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 14 Jul 2010 11:00:24 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 14 13:00:22 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OYzh8-0007vQ-AJ for ged-emacs-devel@m.gmane.org; Wed, 14 Jul 2010 13:00:18 +0200 Original-Received: from localhost ([127.0.0.1]:53395 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYzh5-0006kR-Bu for ged-emacs-devel@m.gmane.org; Wed, 14 Jul 2010 07:00:03 -0400 Original-Received: from [140.186.70.92] (port=39701 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYzgz-0006kM-Q1 for emacs-devel@gnu.org; Wed, 14 Jul 2010 06:59:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OYzgx-00064E-Vs for emacs-devel@gnu.org; Wed, 14 Jul 2010 06:59:57 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:53384) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYzgx-000641-Lb for emacs-devel@gnu.org; Wed, 14 Jul 2010 06:59:55 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OYzgv-0007ql-Ei for emacs-devel@gnu.org; Wed, 14 Jul 2010 12:59:53 +0200 Original-Received: from 27.77.197-77.rev.gaoland.net ([77.197.77.27]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 14 Jul 2010 12:59:53 +0200 Original-Received: from thierry.volpiatto by 27.77.197-77.rev.gaoland.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 14 Jul 2010 12:59:53 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 68 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 27.77.197-77.rev.gaoland.net User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:RsqUtauBGYsGMfXFR3I1IaalcNg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127275 Archived-At: Eli Zaretskii writes: >> From: Thierry Volpiatto >> Cc: emacs-devel@gnu.org >> Date: Wed, 14 Jul 2010 12:07:50 +0200 >> >> Eli Zaretskii writes: >> >> >> From: Thierry Volpiatto >> >> Cc: emacs-devel@gnu.org >> >> Date: Wed, 14 Jul 2010 11:06:13 +0200 >> >> >> >> But i am speaking of the case where contributor's code is modified by Emacs >> >> developers >> > >> > Do you have examples? I think this is done only rarely, and only when >> > the patch is very small. >> >> Most of my patchs including the last. >> See all integration of bookmarking from Gnus/Woman/Man. >> See also the M-g s command in bookmark. > > I don't know where to look in order "to see". Can you show the patch > you submitted for Woman and `man' and point to a revno where its > modified version actually went in? I think i am wrong for these patchs as i can retrieve initial changes i made, and then the Stefan's modifications. So apparently things have been done like i said by stefan: Commit change of contributor and then commit differents changes on top of this patch: (Sorry i have not bzr, i search faster with hg) ,---- | changeset: 107919:c022e0b360db | user: Stefan Monnier | date: Wed Apr 14 11:07:53 2010 -0400 | summary: Add a new field `location' to bookmarks for non-file bookmarks. | | changeset: 107904:1cd2a7cffe3a | user: Stefan Monnier | date: Mon Apr 12 15:12:36 2010 -0400 | summary: * bookmark.el (bookmark-insert-location): Handle a nil filename. | | changeset: 107902:0cafb6c11cbc | user: Stefan Monnier | date: Mon Apr 12 12:09:47 2010 -0400 | summary: Clean up last bookmark changes for man/woman/gnus-summary. | | changeset: 107901:fd86e7cd598a | user: Thierry Volpiatto | date: Mon Apr 12 11:17:29 2010 -0400 | summary: Summary: Add bookmark support for man, woman and gnus-summary. `---- ,---- | changeset: 105941:1225b620227b | user: Stefan Monnier | date: Fri Nov 20 15:47:26 2009 +0000 | summary: * bookmark.el (bookmark-search-delay, bookmark-search-prompt): New options. `---- I remember changes have been done in one of my initial patchs but can't remember which one is it. -- Thierry Volpiatto Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997