Re: [PATCH] ldap.el: use auth-source if passwd is not defined in ldap-host-parameters-list

[Leonidas Tsampros <ltsampros@upnet.gr>]

Ted Zlatanov <tzz@lifelogs.com> writes:

> On Fri, 04 Mar 2011 22:47:20 +0200 Leonidas Tsampros <ltsampros@upnet.gr> wrote:
>
> LT> Attached you can find a small patch to make ldap.el use auth-source if
> LT> passwd is not defined in the ldap-host-parameters-list.
>
> Cool!  I made some changes to it, please let me know what you think:
>
> - must pass `auth-source' set to t in the SEARCH-PLIST to activate this
>   functionality (I don't know if you agree)

Agreed. It's nice not to catch users by surprise.

> - search for 'port "ldap"' entries in the netrc file (should we default
>   to no port?)

This is the only part I disagree a bit. For example, my imap host is the
same with my ldap host, the credentials are the same for both services,
and both imap/ldap use the default ports. (This is a classic case of an
Exchange server I think)

So I was thinking that it might be good idea to use the same authinfo line
for both of them, IN CASE, there is not something more specific in the
authinfo file.

However, I'm not strong about this, and I really didn't mind having a
second authinfo line at all.

> - take the password and use it
>
> - take "binddn" or "user" tokens for `binddn'
>
> - take "base" tokens for `base'
>
> so the user can have a netrc line like this
>
> machine X user Y password Z base B port ldap
>

All of the above are self explanatory, and really thanks for doing it.

> I tried to document it to explain all this.  If I'm going in the wrong
> direction, tell me.  I don't know ldap.el so well.
>
> Ted
>

I tested your patch and I think that it works really great!
Many thanks!

(Really there is no wrong direction in this. We just don't want to carry
passwords in our configuration files. :)